Fix for the TopNList add method#3
Open
finleysg wants to merge 1 commit intotmalaska:masterfrom
finleysg:master
Open
Fix for the TopNList add method#3finleysg wants to merge 1 commit intotmalaska:masterfrom finleysg:master
finleysg wants to merge 1 commit intotmalaska:masterfrom
finleysg:master
Conversation
The original would only add the first N key-values encountered
Author
|
In the original, the top N members of the array would simply be the first N to arrive because the second block: would never allow the thread to get to the third block. The third block also used a .insert() method rather than a .update() method, so if we did reach that block, we would run out of heap memory on a large table. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original would only add the first N key-values encountered