Conversation
Replaced `vec.append(&mut slice.to_vec())` with `vec.extend_from_slice(slice)` in `crates/fhe/src/bfv/ops/mul.rs`. This avoids allocating a temporary vector for the slice content before moving it to the destination vector. Measured performance impact: - Baseline: ~17.04 ms - Optimized: ~17.43 ms - Difference is within noise threshold, but the change avoids unnecessary allocation. Co-authored-by: tlepoint <1345502+tlepoint@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
💡 What:
Replaced
extended_basis.append(&mut ctx.moduli().to_vec());withextended_basis.extend_from_slice(ctx.moduli());incrates/fhe/src/bfv/ops/mul.rs.🎯 Why:
To avoid allocating a temporary
Vecwhen appending a slice to aVec.extend_from_slicecopies elements directly.📊 Measured Improvement:
Measured using a custom criterion benchmark
Multiplicator::default.PR created automatically by Jules for task 1448834772391169533 started by @tlepoint