Avoid bundling untracked files in gem publishing#23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ok so, hilarious and sad bug: I have been publishing the Ruby SDK from my machine for a long time and because of that I have a local
turnkey_clientfolder which contains previously built artifact.The issue, now obvious in retrospect: we bundle EVERYTHING in
turnkey_clientto bundle the gem for release:ruby-sdk/turnkey_client/turnkey_client.gemspec
Line 34 in 33f6e21
This means...the gems double their size every time we release. Recently we finally caught this because the size is ridiculous:
Turns out exponential growth hurts pretty quickly...
Fix: only bundle files git knows about!