This repository was archived by the owner on Apr 26, 2023. It is now read-only.
Fix offset error when ListView has headers, preventing swipe#48
Open
dhleong wants to merge 4 commits intotimroes:masterfrom
Open
Fix offset error when ListView has headers, preventing swipe#48dhleong wants to merge 4 commits intotimroes:masterfrom
dhleong wants to merge 4 commits intotimroes:masterfrom
Conversation
There were several leaks
Otherwise, if a user passes one (for endless scrolling, for example), our "pause" functionality breaks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro:
Add a header view, scroll so header view is off-screen; now, the first item in the ELV won't be scrollable
Also: 2af4137 fixes a bug where the ELV-specified OnScrollListener would be squashed if the user needs to specify their own