fix(cie_thread_configurator): ensure thread info message delivery #31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hread info - Add subscriber discovery wait loop in spawn_non_ros2_thread with 1 second timeout to prevent message loss when publishing NonRosThreadInfo - Add warning when no subscriber is connected for CallbackGroupInfo to guide users to start thread_configurator_node - Backport from tier4/agnocast#967
…y before shutdown Use reliable QoS and wait_for_all_acked() to ensure the message is delivered to subscribers before shutting down the context, fixing flaky test failures in CI environments.
atsushi421
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
spawn_non_ros2_threadwith 1 second timeout to prevent message loss when publishingNonRosThreadInfoCallbackGroupInfoto guide users to startthread_configurator_nodekeep_all()toreliable()for the NonRosThreadInfo publisherwait_for_all_acked(500ms)after publishing to ensure the message is delivered before context shutdownRelated links
How was this PR tested?
thread_configurator_nodeis not runningNotes for reviewers
N/A