feat: parameterize MultiThreadedExecutorInternal configuration #30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow users to configure reentrant_parallelism, yield_before_execute, and next_exec_timeout parameters when using MultiThreadedExecutorInternal for reentrant callback groups. - CallbackIsolatedExecutor: accept parameters via constructor arguments - ComponentManagerCallbackIsolated: accept parameters via ROS parameters (reentrant_parallelism, yield_before_execute, next_exec_timeout_ns) - Update sample application to demonstrate parameter usage
Contributor
There was a problem hiding this comment.
Pull request overview
This PR parameterizes the MultiThreadedExecutorInternal configuration by allowing users to configure reentrant_parallelism, yield_before_execute, and next_exec_timeout parameters for reentrant callback groups.
Changes:
- Added constructor parameters to
CallbackIsolatedExecutorfor configuring reentrant executor behavior - Added ROS parameters to
ComponentManagerCallbackIsolatedfor runtime configuration - Updated
MultiThreadedExecutorInternalconstructor to accept configuration parameters instead of hardcoded values
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
callback_isolated_executor/include/callback_isolated_executor/callback_isolated_executor.hpp |
Added constructor parameters and member variables for reentrant executor configuration |
callback_isolated_executor/src/callback_isolated_executor.cpp |
Updated constructor and reentrant callback group spinning to use configurable parameters |
callback_isolated_executor/include/callback_isolated_executor/multi_threaded_executor_internal.hpp |
Replaced hardcoded values with constructor parameters |
callback_isolated_executor/src/component_container_callback_isolated.cpp |
Added ROS parameter declarations and usage for runtime configuration |
cie_sample_application/src/reentrant_node_main.cpp |
Updated example to use new parameterized constructor |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
callback_isolated_executor/include/callback_isolated_executor/callback_isolated_executor.hpp
Outdated
Show resolved
Hide resolved
callback_isolated_executor/src/component_container_callback_isolated.cpp
Outdated
Show resolved
Hide resolved
- Add default member initializers to CallbackIsolatedExecutor - Validate reentrant_parallelism parameter is non-negative before casting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow users to configure
reentrant_parallelism,yield_before_execute, andnext_exec_timeoutparameters forMultiThreadedExecutorInternalused in reentrant callback groups.CallbackIsolatedExecutor: parameters configurable via constructor argumentsComponentManagerCallbackIsolated: parameters configurable via ROS parameters (reentrant_parallelism,yield_before_execute,next_exec_timeout_ns)Related links
N/A
How was this PR tested?
reentrant_node_mainruns correctly with parameterized executorNotes for reviewers
N/A