-
Notifications
You must be signed in to change notification settings - Fork 350
userspace: proxy: Fix typo in variable name #10432
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Fix typo in variable name from heap_part_cached to heap_cached_part. Fixes thesofproject#10431 Signed-off-by: Adrian Warecki <adrian.warecki@intel.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR corrects a typo in a variable name within the userspace proxy module's memory initialization function. The variable reference is changed from heap_part_cached to heap_cached_part to match the actual variable name defined elsewhere in the codebase.
- Fixed incorrect variable name reference in memory partition array initialization
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kv2019i
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! build-linux now clean: https://github.com/thesofproject/sof/actions/runs/20132638110/job/57777695274?pr=10432
| @@ -74,7 +74,7 @@ static int userspace_proxy_memory_init(struct userspace_context *user, | |||
|
|
|||
| struct k_mem_partition *parts_ptr[] = { | |||
| #ifdef HEAP_PART_CACHED | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we align the Kconfig name in a subsequent PR? It seems like a copy paste type issue.
|
Known issue seen https://sof-ci.01.org/sofpr/PR10432/build17976/devicetest/index.html?model=PTLP_RVP_SDW&testcase=verify-kernel-boot-log . One new in https://sof-ci.01.org/sofpr/PR10432/build17976/devicetest/index.html but this seems to be a DUT specific issue, not related to this PR. Proceeding with merge. |
Fix typo in variable name from
heap_part_cachedtoheap_cached_part.Fixes #10431