Modified addToQueue endpoint & created 2 new endpoints. Added tests for all 3. #477
Open
ddworak44 wants to merge 1 commit intothelinmichael:masterfrom
Open
Modified addToQueue endpoint & created 2 new endpoints. Added tests for all 3. #477ddworak44 wants to merge 1 commit intothelinmichael:masterfrom
ddworak44 wants to merge 1 commit intothelinmichael:masterfrom
Conversation
…ted addToPlayback queue to reflect optional device_id. Added unit tests for all 3 as well as updated documentation in the README
|
Is there an update on merging this pr? With the recent API changes the get-playlist-cover call would be very helpful. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1a. Created function addToPlaybackQueue as shown as TBD on README.md. Function adds an item to a user’s playback queue. 1b. Noticed addToQueue endpoint had optional parameter device_id, which could lead to unexpected behavior. 1c. Added tests in test/spotify-web-api.js to test behavior of new endpoint.
Added getPlaylistoverImage endpoint brought up in Issue Missing endpoint: get-playlist-cover #350. Implementation was missing and added test in test/spotify-web-api.js
Added getAvailableMarkets endpoint, which was missing & available in Spotify Web API documentation.