Conversation
Member
|
Could you please also add jruby to the Travis yml file? |
8b20d2b to
5fd1288
Compare
07e4a26 to
19dfa0e
Compare
19dfa0e to
354ac81
Compare
Member
|
Does the current failure in Travis make sense to you? I don't get it. |
Author
|
It's erroring out trying to start |
Member
|
I just spent a little while looking through this and it looks like there's quite a lot of work left to be done, no? Before this would work, wouldn't we need to implement a second SQLite wrapper based on |
Author
|
Yes I agree, separate implementation of SQLite wrapper for jruby needs to be written. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows suture to be installed on Jruby platform else following error occurs