Skip to content

fix(generator): ensure variadic options in secondary factory methods (#615) #630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sshekhar-04 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(generator): ensure variadic options in secondary factory methods (#615) #630

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion ...e/tensorflow-core-generator/src/main/java/org/tensorflow/generator/op/ClassGenerator.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ enum RenderMode {

/**
* The generated options class, or null if it doesn't have one or {@link #buildOptionsClass()} has
* not been ran.
* not been run.
*/
private TypeSpec optionsClass = null;

Expand Down Expand Up @@ -748,6 +748,10 @@ private void buildSecondaryFactory(
body.add("$T.class", defaultTypes.get(attr));
} else {
factoryBuilder.addParameter(param);
// Checking if the parameter being added is the variadic options or not
if (param.name.equals("options")) {
factoryBuilder.varargs();
}
factoryBuilder.addJavadoc("\n@param $L $L", param.name, paramTags.get(param.name));
typeVars.addAll(new ResolvedType(param.type).findGenerics());
body.add("$L", param.name);
Expand Down