Merged
Conversation
- multiclass works for OHE - fix multiclass test in unit test
Contributor
Author
|
This should work for one hot encoded label. I'll work on sparse labels as well but I wanted to gather some reviews before. Looking forward! :) |
Contributor
|
@ZeynepP Can you test this fix? |
Contributor
Author
|
@bhack I've added test case which confirms that patch solves the issue. Would you mind reviewing this patch? |
Contributor
|
Can we check numerically with https://scikit-learn.org/stable/modules/generated/sklearn.metrics.matthews_corrcoef.html ? |
Contributor
Author
|
Its in the test case :) or do you mean to say I should import sklearn and check their output values? I can do that. |
Contributor
Yes we already have some tests with |
Contributor
Author
|
Done :) |
bhack
reviewed
Mar 29, 2021
conf_matrix use self.dtype
bhack
approved these changes
Apr 2, 2021
21 tasks
lgeiger
reviewed
Jun 2, 2021
tensorflow_addons/metrics/tests/matthews_correlation_coefficient_test.py
Show resolved
Hide resolved
21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Brief Description of the PR:
Fixes # (issue)
#2339
Type of change
Checklist:
How Has This Been Tested?
The issue created by the user is perfectly solved by this
If you're adding a bugfix or new feature please describe the tests that you ran to verify your changes: