Skip to content

Use CountSchedules for counting schedules#3100

Open
lina-temporal wants to merge 4 commits intomainfrom
count-schedules
Open

Use CountSchedules for counting schedules#3100
lina-temporal wants to merge 4 commits intomainfrom
count-schedules

Conversation

@lina-temporal
Copy link

Description & motivation 💭

  • Makes use of the incoming CountSchedules API. Using ListWorkflowExecutions to query schedules has always been private API, and it's about to break with the release of CHASM schedules. This makes use of a public API for both V1 and V2 schedules.

@lina-temporal lina-temporal requested review from a team and Alex-Tideman as code owners January 15, 2026 23:23
@vercel
Copy link

vercel bot commented Jan 15, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
holocene Ready Ready Preview, Comment Feb 3, 2026 0:02am

Request Review

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Jan 15, 2026

Warnings
⚠️

📊 Strict Mode: 37 errors in 2 files (3.3% of 1121 total)

src/lib/utilities/route-for-api.ts (36)
  • L63:48: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
  • L69:50: Element implicitly has an 'any' type because type 'typeof globalThis' has no index signature.
  • L71:4: Type 'string | null' is not assignable to type 'string'.
  • L98:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ namespace: string; workflowId: string; scheduleId: string; queue: string; queryType: string; signalName: string; updateName: string; batchJobId: string; runId: string; activityId: string; endpointId: string; deploymentName: string; version: string; }'.
  • L98:38: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Partial'.
  • L100:8: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type '{ namespace: string; workflowId: string; scheduleId: string; queue: string; queryType: string; signalName: string; updateName: string; batchJobId: string; runId: string; activityId: string; endpointId: string; deploymentName: string; version: string; }'.
  • L100:57: Element implicitly has an 'any' type because expression of type 'string' can't be used to index type 'Partial'.
  • L127:40: Argument of type 'Partial | undefined' is not assignable to parameter of type 'Partial'.
  • L134:40: 'parameters' is possibly 'undefined'.
  • L138:93: 'parameters' is possibly 'undefined'.
  • L151:38: 'parameters' is possibly 'undefined'.
  • L151:72: 'parameters' is possibly 'undefined'.
  • L152:38: 'parameters' is possibly 'undefined'.
  • L152:72: 'parameters' is possibly 'undefined'.
  • L152:104: 'parameters' is possibly 'undefined'.
  • L153:38: 'parameters' is possibly 'undefined'.
  • L153:72: 'parameters' is possibly 'undefined'.
  • L153:104: 'parameters' is possibly 'undefined'.
  • L154:37: 'parameters' is possibly 'undefined'.
  • L154:71: 'parameters' is possibly 'undefined'.
  • L159:40: 'parameters' is possibly 'undefined'.
  • L160:36: 'parameters' is possibly 'undefined'.
  • L161:37: 'parameters' is possibly 'undefined'.
  • L162:39: 'parameters' is possibly 'undefined'.
  • L163:37: 'parameters' is possibly 'undefined'.
  • L164:46: 'parameters' is possibly 'undefined'.
  • L165:44: 'parameters' is possibly 'undefined'.
  • L166:39: 'parameters' is possibly 'undefined'.
  • L168:42: 'parameters' is possibly 'undefined'.
  • L169:49: 'parameters' is possibly 'undefined'.
  • L170:41: 'parameters' is possibly 'undefined'.
  • L171:40: 'parameters' is possibly 'undefined'.
  • L171:83: 'parameters' is possibly 'undefined'.
  • L172:48: 'parameters' is possibly 'undefined'.
  • L172:99: 'parameters' is possibly 'undefined'.
  • L178:16: This overload signature is not compatible with its implementation signature.
src/lib/services/workflow-counts.ts (1)
  • L34:3: Function lacks ending return statement and return type does not include 'undefined'.

Generated by 🚫 dangerJS against 507bcca

@lina-temporal lina-temporal marked this pull request as draft January 28, 2026 01:44
});
return count ?? '0';
} catch (error: unknown) {
if (isNotImplemented(error)) {
Copy link
Collaborator

@laurakwhit laurakwhit Feb 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I'm seeing a 404 Not Found error when running pnpm dev locally.
We might need to account for that as well. We're currently using v1.60.1 in the ui-server and it looks like CountSchedules operation was added in v.1.62.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants