Draft
Conversation
…ould allow us to more easily mock the registration behavior for components using service.Acme
… model creation anymore
…at used to be tested in certificate_test.go
… be in the model tests
…strar. This also allows mocking the lego registration during testing
Contributor
|
Is this still WIP? |
1 similar comment
Contributor
|
Is this still WIP? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOT READY FOR MERGE
Context
The certificate registration was happening inside of the certificate model.
This PR aims to move that to the acme service in a way that also allows us to mock the lego portion so that we can make tests that don't actually rely on attempting to register.
Approach
Coming soon...
Testing
Coming soon...