Open
Conversation
added 2 commits
December 7, 2025 01:29
This PR addresses two main issues: 1. Fixes Vite HMR behind caddy proxy by forcing wss protocol and separate path. 2. Refactors toast error handling to correctly parse and display Headscale API errors that return DataWithResponseInit objects. 3. Limits toast width for better readability.
Owner
|
In my opinion, toasts are not good UX and I want to remove them from Headplane. Instead it might make more sense to leverage the "Notice" component that I use in the |
Author
|
Good to know, ill check out the Notice component ! I dont have a strong opinion either way, just want to see the errors pop up when i make them and not lose progress tbh. |
Owner
|
It should do that, it just diverged with 0.27.1 but I think I've fixed it anyways if you wanna try the main branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Details:
assuming :
my stack;
Headplane Version
v0.6.1
Headscale Version
v0.27.1
on ubuntu running natively behind a cloud proxy
qa:
Issue Details:
#390