[BridgeJS] Support @JS var declarations for global scope imports #505
+410
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s) end-to-end in BridgeJS. - `Plugins/BridgeJS/Sources/BridgeJSCore/ImportSwiftMacros.swift`: collect top-level `@JSGetter` vars into the imported skeleton instead of erroring. - `Plugins/BridgeJS/Sources/BridgeJSSkeleton/BridgeJSSkeleton.swift`: add `ImportedFileSkeleton.globalGetters` (+ Codable backward-compat) and make `ImportedGetterSkeleton.abiName(context:)` accept `nil`. - `Plugins/BridgeJS/Sources/BridgeJSCore/ImportTS.swift`: generate Swift thunks for global getters as `_$<name>_get()` calling the wasm import `bjs_<name>_get`. - `Plugins/BridgeJS/Sources/BridgeJSLink/BridgeJSLink.swift`: generate JS import glue for global getters as `imports["<name>"]` and emit `readonly <name>: <type>` in `Imports`. - Added test+snapshots: `Plugins/BridgeJS/Tests/BridgeJSToolTests/ImportMacroInputs/GlobalGetter.swift`, `Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/GlobalGetter.ImportMacros.js`, `Plugins/BridgeJS/Tests/BridgeJSToolTests/__Snapshots__/BridgeJSLinkTests/GlobalGetter.ImportMacros.d.ts`. - `Plugins/BridgeJS/Package.swift`: exclude `ImportMacroInputs` from being compiled as test sources. Run: `swift test --package-path ./Plugins/BridgeJS` To bind actual globals, pass `globalThis` as the `imports` object on the JS side (so the generated glue reads `imports["console"]`, `imports["document"]`, etc.).
MaxDesiatov
reviewed
Jan 21, 2026
Plugins/BridgeJS/Tests/BridgeJSToolTests/ImportMacroInputs/GlobalGetter.swift
Outdated
Show resolved
Hide resolved
MaxDesiatov
reviewed
Jan 21, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#466