Skip to content

fix: more comprehensive query param encoding#44

Merged
tngraf merged 4 commits intosw360:masterfrom
GuyBrush385:feat/fix_api_params_encoding
Jun 20, 2025
Merged

fix: more comprehensive query param encoding#44
tngraf merged 4 commits intosw360:masterfrom
GuyBrush385:feat/fix_api_params_encoding

Conversation

@GuyBrush385
Copy link

API calls have no comprehensive param encoding.
For most params this is not really an issue but like "find component" can cause mismatches.

@tngraf
Copy link
Collaborator

tngraf commented Jun 16, 2025

Thanks for the PR. Did you test with a real SW360 instance that all parmater encoding works as it should be?
I am asking because some years ago the SW360 REST API was not able to have correctly encoded parameters
everywhere...

@GuyBrush385 GuyBrush385 changed the title fix: comprehensive query param enconding fix: more comprehensive query param encoding Jun 17, 2025
@GuyBrush385
Copy link
Author

I now gone throught the changes the best to my knowledge about sw360 and tested them as good as I could against a real instance.
My guess that the queries build with _add_param did not have the issue with the "not able to process encoded call" but I only touched those. There are quite a few other calls which still just do some basic string concat.

@tngraf tngraf merged commit 884d6a8 into sw360:master Jun 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants