Conversation
Fix legacy pattern matching to be compatible with PHP 7.4+. These changes still work with older versions of php (like 5.2+). PHP 7.4 requires escaping dashes (\-). The only changes are from \w- to \w\- This modernizes while maintaining legacy support.
Author
|
Update regex patterns to work with PHP 7.4-8+ |
|
Would be great if this can be merged. |
Author
@TwinDigitalNL didnt realize anyone else was running into the same issue. I ended up just creating a new packae based on this one since it doesnt look like its maintained anymore. https://bitbucket.org/bmooreitul/php-simple-dom-parser/src/master/ You can use my version until if/when my suggestion ever gets merged.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix legacy pattern matching to be compatible with PHP 7.4+. These changes still work with older versions of php (like 5.2+). PHP 7.4 requires escaping dashes (-).
The only changes are from \w- to \w-
This modernizes while maintaining legacy support.