Skip to content

Refactor/sdp structure cleanup#1126

Open
NimaSarajpoor wants to merge 4 commits intostumpy-dev:mainfrom
NimaSarajpoor:refactor/sdp-structure-cleanup
Open

Refactor/sdp structure cleanup#1126
NimaSarajpoor wants to merge 4 commits intostumpy-dev:mainfrom
NimaSarajpoor:refactor/sdp-structure-cleanup

Conversation

@NimaSarajpoor
Copy link
Collaborator

This is to address PR 1 described in this comment. Have copied the corresponding notes below:

  1. Create a new sdp.py file
  2. Move _sliding_dot_product to sdp.py and call it _njit_sliding_dot_product
  3. Removing the core._sliding_dot_product altogether (currently, you are keeping both and calling one from the other. This is a bad idea)
  4. Replace all (three) references to core._sliding_dot_product with sdp._njit_sliding_dot_product
  5. Update move tests from tests/test_core.py to tests/test_sdp.py
  6. Add an sdp._sliding_dot_product that simply calls _njit_sliding_dot_product (complexity gets added in future PRs)
  7. Make core.sliding_dot_product = sdp._sliding_dot_product

@gitnotebooks
Copy link

gitnotebooks bot commented Feb 7, 2026

Review these changes at https://app.gitnotebooks.com/stumpy-dev/stumpy/pull/1126

@NimaSarajpoor
Copy link
Collaborator Author

NimaSarajpoor commented Feb 7, 2026

@seanlaw
We also need to modify Tutorial_DiscordMERLIN.ipynb as it uses core._sliding_dot_product, and need to run the whole notebook again. However, the problem is that the notebook loads data from directories that do not exist. Also, the data provided by MERLIN webpage is not accessible anymore.

Copy link
Contributor

@seanlaw seanlaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NimaSarajpoor Looking good! This is much easier to track

@NimaSarajpoor
Copy link
Collaborator Author

We also need to modify Tutorial_DiscordMERLIN.ipynb as it uses core._sliding_dot_product, and need to run the whole notebook again. However, the problem is that the notebook loads data from directories that do not exist. Also, the data provided by MERLIN webpage is not accessible anymore.

I've also noticed that the code in the notebook requires some updates. For instance, in the notebook, I see:

T, M_T, Σ_T = core.preprocess(ts, m)

However, this function in branch main now returns four values instead of three.

@seanlaw
This notebook is outdated. I think we should submit an issue for this, and address it later and separately.

@seanlaw
Copy link
Contributor

seanlaw commented Feb 8, 2026

This notebook is outdated. I think we should submit an issue for this, and address it later and separately.

I agree with that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants