Square Face Improvements#3
Open
dimitribouniol wants to merge 9 commits intosteventroughtonsmith:masterfrom
Open
Square Face Improvements#3dimitribouniol wants to merge 9 commits intosteventroughtonsmith:masterfrom
dimitribouniol wants to merge 9 commits intosteventroughtonsmith:masterfrom
Conversation
Author
|
|
Author
|
Also, the simulator was acting pretty wonky, so I wasn't sure what radius to use (I tried to guess by understanding the math you had, but couldn't figure it out), so I settled on 16. Feel free to adjust accordingly.
|
Author
|
@steventroughtonsmith Now with some real math ;) (You can use the provided functions to easily calculate where the center of a circular tick mark should be placed by drawing the appropriate CGPathRef, for instance) |
|
i think my PR (#18) may fix the issue you see here #3 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use a mask for the square face instead of trying to get complicated math to work reliably ;)