Skip to content

Fix TLS not enabling for dynamic fastly backends #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ChristianPavilonis wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix TLS not enabling for dynamic fastly backends #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions crates/edgezero-adapter-fastly/src/proxy.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,23 @@ fn ensure_backend(uri: &Uri) -> Result<Backend, EdgeError> {
None => host.to_string(),
};

let builder = Backend::builder(&name, &host_with_port).override_host(host);
let mut builder = Backend::builder(&name, &host_with_port).override_host(host);
if uri.scheme_str() == Some("https") {
builder = builder
.enable_ssl()
.sni_hostname(host)
.check_certificate(host);
Copy link
Contributor

@aram356 aram356 Jan 30, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏕️ In development we need to allow to disable check certificates See #36

}

match builder.finish() {
Ok(backend) => Ok(backend),
Err(_) => {
let mut builder = Backend::builder(&name, &target);
if uri.scheme_str() == Some("https") {
builder = builder.enable_ssl();
Copy link
Contributor Author

@ChristianPavilonis ChristianPavilonis Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason this tries again without port?

trusted server doesn't do this.

Copy link
Contributor

@aram356 aram356 Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is legacy and was not tested in production

builder = builder
.enable_ssl()
.sni_hostname(host)
.check_certificate(host);
}
builder.finish().map_err(EdgeError::internal)
}
Expand Down