Skip to content

feat(iaas): List NICs for Project #1242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Manuelvaas wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(iaas): List NICs for Project #1242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions docs/stackit_network-interface_list.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ stackit network-interface list [flags]
### Examples

```
Lists all network interfaces in your current project
$ stackit network-interface list

Lists all network interfaces with network ID "xxx"
$ stackit network-interface list --network-id xxx

Expand Down
59 changes: 43 additions & 16 deletions internal/cmd/network-interface/list/list.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,13 +33,21 @@ type inputModel struct {
NetworkId string
}

type ExecutableRequest interface {
Execute() (*iaas.NICListResponse, error)
}

func NewCmd(params *types.CmdParams) *cobra.Command {
cmd := &cobra.Command{
Use: "list",
Short: "Lists all network interfaces of a network",
Long: "Lists all network interfaces of a network.",
Args: args.NoArgs,
Example: examples.Build(
examples.NewExample(
`Lists all network interfaces in your current project`,
`$ stackit network-interface list`,
),
examples.NewExample(
`Lists all network interfaces with network ID "xxx"`,
`$ stackit network-interface list --network-id xxx`,
Expand Down Expand Up @@ -71,22 +79,26 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
}

// Call API
req := buildRequest(ctx, model, apiClient)
resp, err := req.Execute()
if err != nil {
return fmt.Errorf("list network interfaces: %w", err)
}

if resp.Items == nil || len(*resp.Items) == 0 {
networkLabel, err := iaasUtils.GetNetworkName(ctx, apiClient, model.ProjectId, model.Region, model.NetworkId)
var req ExecutableRequest
var networkLabel = ""
if model.NetworkId == "" {
// Return all NICs in the Project
req = buildProjectRequest(ctx, model, apiClient)
} else {
// Return the NICs for one Network
req = buildRequest(ctx, model, apiClient)

networkLabel, err = iaasUtils.GetNetworkName(ctx, apiClient, model.ProjectId, model.Region, model.NetworkId)
if err != nil {
params.Printer.Debug(print.ErrorLevel, "get network name: %v", err)
networkLabel = model.NetworkId
} else if networkLabel == "" {
networkLabel = model.NetworkId
}
params.Printer.Info("No network interfaces found for network %q\n", networkLabel)
return nil
}
resp, err := req.Execute()
if err != nil {
return fmt.Errorf("list network interfaces: %w", err)
}

// Truncate output
Expand All @@ -95,7 +107,7 @@ func NewCmd(params *types.CmdParams) *cobra.Command {
items = items[:*model.Limit]
}

return outputResult(params.Printer, model.OutputFormat, items)
return outputResult(params.Printer, model.OutputFormat, items, networkLabel)
},
}
configureFlags(cmd)
Expand All @@ -106,9 +118,6 @@ func configureFlags(cmd *cobra.Command) {
cmd.Flags().Var(flags.UUIDFlag(), networkIdFlag, "Network ID")
cmd.Flags().Int64(limitFlag, 0, "Maximum number of entries to list")
cmd.Flags().String(labelSelectorFlag, "", "Filter by label")

err := flags.MarkFlagsRequired(cmd, networkIdFlag)
cobra.CheckErr(err)
}

func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel, error) {
Expand Down Expand Up @@ -136,7 +145,16 @@ func parseInput(p *print.Printer, cmd *cobra.Command, _ []string) (*inputModel,
return &model, nil
}

func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) iaas.ApiListNicsRequest {
func buildProjectRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) ExecutableRequest {
req := apiClient.ListProjectNICs(ctx, model.ProjectId, model.Region)
if model.LabelSelector != nil {
req = req.LabelSelector(*model.LabelSelector)
}

return req
}

func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APIClient) ExecutableRequest {
req := apiClient.ListNics(ctx, model.ProjectId, model.Region, model.NetworkId)
if model.LabelSelector != nil {
req = req.LabelSelector(*model.LabelSelector)
Expand All @@ -145,8 +163,17 @@ func buildRequest(ctx context.Context, model *inputModel, apiClient *iaas.APICli
return req
}

func outputResult(p *print.Printer, outputFormat string, nics []iaas.NIC) error {
func outputResult(p *print.Printer, outputFormat string, nics []iaas.NIC, networkLabel string) error {
return p.OutputResult(outputFormat, nics, func() error {
if nics == nil || len(nics) == 0 {
if networkLabel == "" {
p.Outputf("No network interfaces found for your current project\n")
} else {
p.Outputf("No network interfaces found for network %q\n", networkLabel)
}
return nil
}

table := tables.NewTable()
table.SetHeader("ID", "NAME", "NIC SECURITY", "DEVICE ID", "IPv4 ADDRESS", "STATUS", "TYPE")

Expand Down
Loading