You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@marckhouzam Not at all.
Assuming we want to add a new flag named myFlag with shorthand h to a flagset named myFlagSet:
Before the message would read: unable to redefine 'h' shorthand in "myFlagSet" flagset: it's already used for "myFlag" flag
Now it reads: unable to define 'h' shorthand for "help" flag: it's already used for "myFlag" flag
Considering the linked issue, the custom flag is set first, after that the help flag creation is initiated and results to that panic.
Especially in case of using h shorthand, the message is more vague for the user as they might not know that help with the same shorthand is being initiated later and causing that error.
But I believe the new message is clearer in all the situations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This aims to fix this issue