Feature kpoland dataset new version #227
Open
+4,093
−4,311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klpoland
added
feature
Collaborator
Author
|
In this PR:
|
klpoland
force-pushed
the
feature-kpoland-dataset-new-version
branch
from
f639183 to
6af27e8
Compare
Collaborator
Author
|
For Monday: Added versioning AND consolidated some javascript functionality (which is why there's so many deletions). Refactoring/updating tests in Jest and Python to match and pushing that shortly.... |
lucaspar
requested changes
Jan 27, 2026
| is_deleted=False, | ||
| ).first() | ||
|
|
||
| return permission.permission_level in ["co-owner"] |
Member
There was a problem hiding this comment.
permission could be None here, which would raise a AttributeError: 'NoneType' object has no attribute ...
Member
There was a problem hiding this comment.
just checking if these "keyword" removals are intentional
Comment on lines
+3341
to
+3342
| "created_at", | ||
| "updated_at", |
Member
There was a problem hiding this comment.
maybe we should reset these timestamp flags for a new version, instead?
|
|
||
| // Store dataset info in the download button (find within this specific modal) | ||
| const confirmBtn = modal.querySelector('#confirmWebDownloadBtn'); | ||
| if (confirmBtn) { |
Member
There was a problem hiding this comment.
[nit] you could do an early return if false, instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.