ToMap.tsx with improved localityID lookup#7686
Open
nfshoobs wants to merge 1 commit intospecify:mainfrom
Open
Conversation
When DISTINCT is TRUE, the backend deduplicates fields in the query, causing the columnIndex values in localityMappings to point to wrong positions which in turn causes GeoMap plugin to throw a 404 error when a pin is clicked. This issue does not appear to occur in queries where DISTINCT is FALSE. The solution I propose here is to find localityId by following the same path as latitude1/longitude1 rather than assuming it exists in the query results. This is Claude-generated code and I have not tested it, but hopefully this is a step in the right direction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This update is an attempt to fix the problem of GeoMap plugin causing 404 errors due to columnIndex mismatch errors. Instead of assuming the localityID exists in the query results (which it does not in distinct queries) we lookup the localityId via the API using the same path as lat1/long1 for each query row, hopefully circumventing the issue with column index mismatch in distinct and non-distinct queries.
This is LLM-generated code and I have not tested it because I don't have a proper environment to do so, but hopefully this is a step in the right direction and not total garbage.
@grantfitzsimmons can you check this out when you have a chance?
Fixes #7685
Checklist
self-explanatory (or properly documented)
Testing instructions
localitywith lat1 and long1 fields in the query.