Skip to content

fix: removed add button from SpAppResource table#7684

Open
kwhuber wants to merge 1 commit intomainfrom
issue-4950
Open

fix: removed add button from SpAppResource table#7684
kwhuber wants to merge 1 commit intomainfrom
issue-4950

Conversation

@kwhuber
Copy link
Contributor

@kwhuber kwhuber commented Feb 4, 2026

Fixes #4950

This fix removes the add button from the SpAppResouce table. In the UI, this is noticeable when you navigate to User Tools --> App Resources --> Collection Preferences. At the bottom right of the screen, only a save button appears now as the add button did not serve a necessary purpose. This is because SpAppResouce stores app resources like reports, labels, JSON configs, etc and such settings can be applied through the save button.

The change comes by adding SpAppResource to the FORBID_ADDING set in ResourceView.tsx:

export const FORBID_ADDING = new Set<keyof Tables>([
'TaxonTreeDef',
'GeographyTreeDef',
'StorageTreeDef',
'GeologicTimePeriodTreeDef',
'GeologicTimePeriodTreeDefItem',
'TectonicUnitTreeDef',
'LithoStratTreeDef',
'Institution',
'Division',
'Discipline',
'Collection',
/*
* SpecifyUser's should be created through the Security and Accounts tool.
* To properly clone a user need to also clone their roles and policies too
*/
'SpecifyUser',
// See https://github.com/specify/specify7/issues/1754
'Attachment',
'SpAppResource',
]);

Checklist

  • Self-review the PR after opening it to make sure the changes look good and
    self-explanatory (or properly documented)
  • Add relevant issue to release milestone
  • Add pr to documentation list
  • Add automated tests
  • Add a reverse migration if a migration is present in the PR

Testing instructions

  • Go to app resources, click on collection preferences, and verify that the add button is absent

@kwhuber kwhuber added this to the 7.12.0 milestone Feb 4, 2026
@kwhuber kwhuber requested a review from a team February 4, 2026 20:56
@github-project-automation github-project-automation bot moved this to 📋Back Log in General Tester Board Feb 4, 2026
@kwhuber
Copy link
Contributor Author

kwhuber commented Feb 4, 2026

As an aside, I have a comment about a couple minor UI bugs regarding the save button within collection preferences depending on where it's accessed.

For example, going through the route of User Tools --> App Resources --> Collection Preferences, the save button begins as grayed out. After making edits but then returning to default state, it reappears as its beginning grayed out state. It makes more sense to have this be a functional close button.

Screen.Recording.2026-02-04.at.3.02.58.PM.mov

Going straight to User Tools --> Collection Preferences, there is a functional close button as default. This makes sense! However, if I alter the page by selecting and unselecting options, I can never return to the beginning state close button its manipulated back to its default state.

Screen.Recording.2026-02-04.at.3.04.25.PM.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 📋Back Log

Development

Successfully merging this pull request may close these issues.

Add button in collection preferences gives a 404 error

1 participant