fix: removed add button from SpAppResource table#7684
Open
Conversation
Contributor
Author
|
As an aside, I have a comment about a couple minor UI bugs regarding the save button within collection preferences depending on where it's accessed. For example, going through the route of User Tools --> App Resources --> Collection Preferences, the save button begins as grayed out. After making edits but then returning to default state, it reappears as its beginning grayed out state. It makes more sense to have this be a functional close button. Screen.Recording.2026-02-04.at.3.02.58.PM.movGoing straight to User Tools --> Collection Preferences, there is a functional close button as default. This makes sense! However, if I alter the page by selecting and unselecting options, I can never return to the beginning state close button its manipulated back to its default state. Screen.Recording.2026-02-04.at.3.04.25.PM.mov |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4950
This fix removes the add button from the
SpAppResoucetable. In the UI, this is noticeable when you navigate to User Tools --> App Resources --> Collection Preferences. At the bottom right of the screen, only a save button appears now as the add button did not serve a necessary purpose. This is becauseSpAppResoucestores app resources like reports, labels, JSON configs, etc and such settings can be applied through the save button.The change comes by adding
SpAppResourceto theFORBID_ADDINGset inResourceView.tsx:specify7/specifyweb/frontend/js_src/lib/components/Forms/ResourceView.tsx
Lines 40 to 60 in d1f9f23
Checklist
self-explanatory (or properly documented)
Testing instructions