WB Attachments: Fix possible attachment column check crash#7420
Open
WB Attachments: Fix possible attachment column check crash#7420
Conversation
Triggered by 9a01a78 on branch refs/heads/issue-7283
Triggered by 79190ff on branch refs/heads/issue-7283
CarolineDenis
approved these changes
Sep 23, 2025
emenslin
requested changes
Sep 23, 2025
Collaborator
emenslin
left a comment
There was a problem hiding this comment.
- No errors when viewing or clicking around the spreadsheet.
- No errors when viewing or clicking around the attachment data set. The attachment sidebar should also appear.
I'm getting this error in the console when opening an imported dataset that I don't get in main. I'm requesting changes in case this could cause problems but if it's not a big deal then I can approve.
Link to the dataset: https://ojsmnh20250910-issue-7283.test.specifysystems.org/specify/workbench/560
Contributor
Author
I could recreate it on your database on that dataset but not on my database, I'm not sure what conditions cause that exactly. The error looks like it might be caused by this PR so I'm going to look into it once I have time. |
acwhite211
approved these changes
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fixes #7419
Checklist
self-explanatory (or properly documented)
Testing instructions