Update default version of require.js #853
Open
kasium wants to merge 1 commit intospatialaudio:masterfrom
Open
Conversation
Member
|
Thanks for this PR! Sadly, it doesn't seem to work, see the rendered documentation of "widgets": https://nbsphinx--853.org.readthedocs.build/en/853/code-cells.html#Interactive-Widgets-(HTML-only) There's an error in the JavaScript console that's probably related: |
Author
|
Good point, I'm not an expert in this area. For the issue raised in my project updating require.js was the solution. I'm also confused that a patch level increase can cause this issue. Let me check the changelog |
Author
|
Mhm, there is no changelog and the changes don't look related: requirejs/requirejs@2.3.4...2.3.7 However when lookin into other PRs like #849 I think your CI is broken :-) |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #851