Implemented guild experiments by BanTheNons · Pull Request #389 · spacebarchat/server

BanTheNons · 2021-09-21T19:34:49Z

No description provided.

commit e587b8f81f366b175a042ef1eb96e44bc8807570 Author: BuildTools <59115290+BanTheNons@users.noreply.github.com> Date: Tue Sep 21 19:19:57 2021 +0300 Create guild_experiments.example.json commit 9cb03c85618d62e3501146e96539e2c0c79416a3 Author: BuildTools <59115290+BanTheNons@users.noreply.github.com> Date: Tue Sep 21 22:32:07 2021 +0300 Update Identify.ts commit 3b0e0bb116841c460f41b7429a59a577f61e3863 Author: BanTheNons <59115290+BanTheNons@users.noreply.github.com> Date: Tue Sep 21 16:56:14 2021 +0300 implemented guild experiments commit 489af5182d8c69f46b468f010480c88565fbb42f Author: BuildTools <59115290+BanTheNons@users.noreply.github.com> Date: Tue Sep 21 22:26:53 2021 +0300 Update .gitignore

DiegoMagdaleno · 2021-09-22T15:29:09Z

Maybe we should wait for FOSScord to have proper support to handle some of this experiments?

DiegoMagdaleno · 2021-09-22T15:30:34Z

api/src/routes/experiments.json

@@ -0,0 +1,4 @@
+{
+    "experiments": {"fingerprint": "889800254663311382.rgUouuEkLbQi0SGiEMClnfgNZic", "assignments": [[4047587481, 0, 0, -1, 0], [1865079242, 0, 1, -1, 0], [3816091942, 3, 0, -1, 0], [4130837190, 0, 10, -1, 0], [1861568052, 0, 1, -1, 0], [1578940118, 1, 1, -1, 0], [1571676964, 0, 1, -1, 2], [1658164312, 2, 1, -1, 0], [98883956, 1, 1, -1, 0], [3114091169, 0, 1, -1, 0], [2570684145, 4, 1, -1, 2], [4007615411, 0, 1, -1, 0], [852550504, 3, 1, -1, 0], [4168223991, 0, 1, -1, 0], [478613943, 2, 1, -1, 1], [284670956, 0, 1, -1, 0], [2099185390, 0, 1, -1, 0], [1202202685, 0, 1, -1, 0], [3633864632, 0, 1, -1, 0], [3103053065, 0, 1, -1, 0], [820624960, 0, 1, -1, 0], [2599708267, 0, 1, -1, 0], [2885186814, 0, 1, -1, 0], [221503477, 0, 1, -1, 0], [1054317075, 0, 1, -1, 3], [683872522, 0, 1, -1, 1], [1739278764, 0, 2, -1, 0], [2855249023, 0, 1, -1, 0], [3721841948, 0, 1, -1, 0], [1365487849, 6, 1, -1, 0], [955229746, 0, 1, -1, 0], [3128009767, 0, 10, -1, 0], [441885003, 0, 1, -1, 0], [3433971238, 0, 1, -1, 2], [1038765354, 3, 1, -1, 0], [2973729510, 2, 1, -1, 0], [3884442008, 0, 1, -1, 0], [978673395, 1, 1, -1, 0], [4050927174, 0, 1, -1, 0], [1260103069, 0, 1, -1, 0], [4168894280, 0, 1, -1, 0], [2003494159, 1, 1, -1, 0], [2458926251, 1, 6, -1, 2], [4027800, 1, 6, -1, 3], [51193042, 0, 1, -1, 0], [2063302207, 1, 6, -1, 4], [2634540382, 3, 1, -1, 0], [886364171, 0, 1, -1, 0], [427713714, 0, 1, -1, 0], [3388129398, 0, 1, -1, 0], [446728522, 0, 1, -1, 0], [3305874255, 0, 1, -1, 0], [3316720711, 0, 1, -1, 0], [1126477623, 0, 1, -1, 0], [2617218444, 4, 1, -1, 2], [3615263239, 0, 1, -1, 0], [3035674767, 0, 1, -1, 0], [261678880, 0, 1, -1, 0], [144783748, 0, 1, -1, 0], [2898830675, 0, 1, -1, 0], [2311413706, 0, 1, -1, 0], [1304635016, 0, 1, -1, 0], [3840356350, 4, 1, -1, 0], [1047093347, 0, 1, -1, 2], [3354177721, 0, 1, -1, 0], [3643362751, 0, 1, -1, 0], [698017395, 0, 1, -1, 0], [902020832, 3, 3, -1, 1], [2165627712, 2, 1, -1, 0], [3346844407, 0, 1, -1, 0], [3753034466, 1, 2, -1, 0], [881221695, 1, 1, -1, 0], [2144100145, 0, 1, -1, 0], [3749399219, 0, 0, -1, 0], [55060776, 1, 2, -1, 0], [3125584553, 1, 1, -1, 0], [2906015343, 2, 0, -1, 0], [219203323, 1, 1, -1, 0], [2854861606, 0, 1, -1, 1], [3884403666, 1, 1, -1, 0], [1041569008, 0, 1, -1, 0], [2780619238, 1, 1, -1, 0], [2839301427, 1, 1, -1, 0], [2481496956, 0, 1, -1, 0], [1305004983, 0, 1, -1, 0], [126562871, 2, 2, -1, 0], [3296195750, 0, 0, -1, 0]]},


Is this the only way to do it?.

It doesn't look very readable.

It just sends the list of all experiments. It's definitely not readable, and we'll have to blame discord for that.

api/src/routes/experiments.ts

DiegoMagdaleno

Just some issues with the code style, once those are fixed, it is good to go.

erkinalp · 2021-09-22T17:25:42Z

Maybe we should wait for FOSScord to have proper support to handle some of this experiments?

Something like /policies/features/guilds/:id, so that the server operator could configure features per guild?

BanTheNons · 2021-09-28T04:53:10Z

Something like /policies/features/guilds/:id, so that the server operator could configure features per guild?

Guild IDs can be added as overrides in the guild_experiments.json file, if you could only enable experiments per guild you wouldn't be able to set rollouts for it.

You can just rename guild_experments.example.json and you should be good to go.

samuelscheit

We shouldn't save the experiment overrides in a file, as it would create inconsistency between the gateway and api and between multiple deployments.
Instead we should save them in the database as a simple JSON string (for now).

erkinalp · 2021-10-14T18:14:33Z

gateway/src/util/Experiments.ts

+        switch(filter[0]){
+          case 1604612045: //guild_has_feature
+            parse = {
+              type: "guild_has_feature"
+            }
+            filter[1].forEach(function(filterData){
+              if(filterData[0] == 1183251248){ //guild_features
+                parse.guild_features = filterData[1]
+              } else {
+                console.log('[EXPERIMENT] Expected guild_features, got ' + filterData)
+              }
+            })
+            parsedFilters.push(parse)
+            break;
+          case 3013771838: //guild_ids
+            parse = {
+              type: "guild_ids"
+            }
+            filter[1].forEach(function(filterData){
+              if(filterData[0] == 3013771838){ //guild_ids
+                parse.ids = filterData[1]
+              } else {
+                console.log('[EXPERIMENT] Expected guild_ids, got ' + filterData)
+              }
+            })
+            parsedFilters.push(parse)
+            break;
+          case 2404720969: //guild_id_range
+            parse = {
+              type: "guild_id_range"
+            }
+            filter[1].forEach(function(filterData){
+              if(filterData[0] == 3399957344){ //min_id
+                parse.min_id = filterData[1]
+              } else if(filterData[0] == 1238858341){ //max_id
+                parse.max_id = filterData[1]
+              } else {
+                console.log('[EXPERIMENT] Expected min_id or max_id, got ' + filterData)
+              }
+            })
+            parsedFilters.push(parse)
+            break;
+          case 2918402255: //guild_member_count_range
+            parse = {
+              type: "guild_member_count_range"
+            }
+            filter[1].forEach(function(filterData){
+              if(filterData[0] == 3399957344){ //min_id
+                parse.min_id = filterData[1]
+              } else if(filterData[0] == 1238858341){ //max_id
+                parse.max_id = filterData[1]
+              } else {
+                console.log('[EXPERIMENT] Expected min_id or max_id, got ' + filterData)
+              }
+            })
+            parsedFilters.push(parse)
+            break;
+          default:
+            parsedFilters.push({
+              type: "unknown_filter",
+              hash: filter[0],
+              data: filter[1]
+            })
+            break;
+        }
+      })


TODO: implement filter selection as a snowflake-indexed vtable (an object with snowflakes as keys, and filter functions as values)

erkinalp · 2021-10-14T18:15:45Z

gateway/src/opcodes/experiments.json

-]
+[[4047587481, 0, 0, -1, 0], [1865079242, 0, 1, -1, 0], [3816091942, 3, 0, -1, 0], [4130837190, 0, 10, -1, 0], [1861568052, 0, 1, -1, 0], [1578940118, 1, 1, -1, 0], [1571676964, 0, 1, -1, 2], [1658164312, 2, 1, -1, 0], [98883956, 1, 1, -1, 0], [3114091169, 0, 1, -1, 0], [2570684145, 4, 1, -1, 2], [4007615411, 0, 1, -1, 0], [852550504, 3, 1, -1, 0], [4168223991, 0, 1, -1, 0], [478613943, 2, 1, -1, 1], [284670956, 0, 1, -1, 0], [2099185390, 0, 1, -1, 0], [1202202685, 0, 1, -1, 0], [3633864632, 0, 1, -1, 0], [3103053065, 0, 1, -1, 0], [820624960, 0, 1, -1, 0], [2599708267, 0, 1, -1, 0], [2885186814, 0, 1, -1, 0], [221503477, 0, 1, -1, 0], [1054317075, 0, 1, -1, 3], [683872522, 0, 1, -1, 1], [1739278764, 0, 2, -1, 0], [2855249023, 0, 1, -1, 0], [3721841948, 0, 1, -1, 0], [1365487849, 6, 1, -1, 0], [955229746, 0, 1, -1, 0], [3128009767, 0, 10, -1, 0], [441885003, 0, 1, -1, 0], [3433971238, 0, 1, -1, 2], [1038765354, 3, 1, -1, 0], [2973729510, 2, 1, -1, 0], [3884442008, 0, 1, -1, 0], [978673395, 1, 1, -1, 0], [4050927174, 0, 1, -1, 0], [1260103069, 0, 1, -1, 0], [4168894280, 0, 1, -1, 0], [2003494159, 1, 1, -1, 0], [2458926251, 1, 6, -1, 2], [4027800, 1, 6, -1, 3], [51193042, 0, 1, -1, 0], [2063302207, 1, 6, -1, 4], [2634540382, 3, 1, -1, 0], [886364171, 0, 1, -1, 0], [427713714, 0, 1, -1, 0], [3388129398, 0, 1, -1, 0], [446728522, 0, 1, -1, 0], [3305874255, 0, 1, -1, 0], [3316720711, 0, 1, -1, 0], [1126477623, 0, 1, -1, 0], [2617218444, 4, 1, -1, 2], [3615263239, 0, 1, -1, 0], [3035674767, 0, 1, -1, 0], [261678880, 0, 1, -1, 0], [144783748, 0, 1, -1, 0], [2898830675, 0, 1, -1, 0], [2311413706, 0, 1, -1, 0], [1304635016, 0, 1, -1, 0], [3840356350, 4, 1, -1, 0], [1047093347, 0, 1, -1, 2], [3354177721, 0, 1, -1, 0], [3643362751, 0, 1, -1, 0], [698017395, 0, 1, -1, 0], [902020832, 3, 3, -1, 1], [2165627712, 2, 1, -1, 0], [3346844407, 0, 1, -1, 0], [3753034466, 1, 2, -1, 0], [881221695, 1, 1, -1, 0], [2144100145, 0, 1, -1, 0], [3749399219, 0, 0, -1, 0], [55060776, 1, 2, -1, 0], [3125584553, 1, 1, -1, 0], [2906015343, 2, 0, -1, 0], [219203323, 1, 1, -1, 0], [2854861606, 0, 1, -1, 1], [3884403666, 1, 1, -1, 0], [1041569008, 0, 1, -1, 0], [2780619238, 1, 1, -1, 0], [2839301427, 1, 1, -1, 0], [2481496956, 0, 1, -1, 0], [1305004983, 0, 1, -1, 0], [126562871, 2, 2, -1, 0], [3296195750, 0, 0, -1, 0]]


TODO: Fetch experiments from instance DB

erkinalp

Rebase against updated dependencies

BanTheNons added 3 commits September 21, 2021 22:33

Update guild_experiments.json

445189c

compile json files

e200c7b

DiegoMagdaleno requested review from DiegoMagdaleno and samuelscheit September 22, 2021 15:29

DiegoMagdaleno reviewed Sep 22, 2021

View reviewed changes

samuelscheit reviewed Sep 22, 2021

View reviewed changes

api/src/routes/experiments.ts Outdated Show resolved Hide resolved

DiegoMagdaleno self-requested a review September 22, 2021 15:42

DiegoMagdaleno reviewed Sep 22, 2021

View reviewed changes

BanTheNons added 2 commits September 28, 2021 08:00

Update experiments.ts

e972703

Delete guild_experiments.json

5a6421f

You can just rename guild_experments.example.json and you should be good to go.

BanTheNons requested a review from samuelscheit September 28, 2021 05:09

DiegoMagdaleno previously approved these changes Sep 28, 2021

View reviewed changes

Merge branch 'master' into pr/BanTheNons/389

bd9bd05

samuelscheit requested changes Sep 28, 2021

View reviewed changes

erkinalp reviewed Oct 14, 2021

View reviewed changes

erkinalp approved these changes Oct 14, 2021

View reviewed changes

samuelscheit marked this pull request as draft October 14, 2021 22:40

DiegoMagdaleno requested review from DiegoMagdaleno and samuelscheit October 15, 2021 00:21

samuelscheit added this to the Discord Core milestone Oct 16, 2021

erkinalp suggested changes Jan 25, 2022

View reviewed changes

TheArcaneBrony added the Needs rebase Attempt to merge into master label Sep 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implemented guild experiments#389

Implemented guild experiments#389
BanTheNons wants to merge 6 commits intospacebarchat:legacyfrom
BanTheNons:guild-experiments

BanTheNons commented Sep 21, 2021

Uh oh!

DiegoMagdaleno commented Sep 22, 2021

Uh oh!

DiegoMagdaleno Sep 22, 2021

Uh oh!

BanTheNons Sep 28, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DiegoMagdaleno left a comment

Uh oh!

erkinalp commented Sep 22, 2021 •

edited

Loading

Uh oh!

BanTheNons commented Sep 28, 2021

Uh oh!

samuelscheit left a comment •

edited

Loading

Uh oh!

erkinalp Oct 14, 2021 •

edited

Loading

Uh oh!

erkinalp Oct 14, 2021

Uh oh!

erkinalp left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

		@@ -0,0 +1,4 @@
		{
		"experiments": {"fingerprint": "889800254663311382.rgUouuEkLbQi0SGiEMClnfgNZic", "assignments": [[4047587481, 0, 0, -1, 0], [1865079242, 0, 1, -1, 0], [3816091942, 3, 0, -1, 0], [4130837190, 0, 10, -1, 0], [1861568052, 0, 1, -1, 0], [1578940118, 1, 1, -1, 0], [1571676964, 0, 1, -1, 2], [1658164312, 2, 1, -1, 0], [98883956, 1, 1, -1, 0], [3114091169, 0, 1, -1, 0], [2570684145, 4, 1, -1, 2], [4007615411, 0, 1, -1, 0], [852550504, 3, 1, -1, 0], [4168223991, 0, 1, -1, 0], [478613943, 2, 1, -1, 1], [284670956, 0, 1, -1, 0], [2099185390, 0, 1, -1, 0], [1202202685, 0, 1, -1, 0], [3633864632, 0, 1, -1, 0], [3103053065, 0, 1, -1, 0], [820624960, 0, 1, -1, 0], [2599708267, 0, 1, -1, 0], [2885186814, 0, 1, -1, 0], [221503477, 0, 1, -1, 0], [1054317075, 0, 1, -1, 3], [683872522, 0, 1, -1, 1], [1739278764, 0, 2, -1, 0], [2855249023, 0, 1, -1, 0], [3721841948, 0, 1, -1, 0], [1365487849, 6, 1, -1, 0], [955229746, 0, 1, -1, 0], [3128009767, 0, 10, -1, 0], [441885003, 0, 1, -1, 0], [3433971238, 0, 1, -1, 2], [1038765354, 3, 1, -1, 0], [2973729510, 2, 1, -1, 0], [3884442008, 0, 1, -1, 0], [978673395, 1, 1, -1, 0], [4050927174, 0, 1, -1, 0], [1260103069, 0, 1, -1, 0], [4168894280, 0, 1, -1, 0], [2003494159, 1, 1, -1, 0], [2458926251, 1, 6, -1, 2], [4027800, 1, 6, -1, 3], [51193042, 0, 1, -1, 0], [2063302207, 1, 6, -1, 4], [2634540382, 3, 1, -1, 0], [886364171, 0, 1, -1, 0], [427713714, 0, 1, -1, 0], [3388129398, 0, 1, -1, 0], [446728522, 0, 1, -1, 0], [3305874255, 0, 1, -1, 0], [3316720711, 0, 1, -1, 0], [1126477623, 0, 1, -1, 0], [2617218444, 4, 1, -1, 2], [3615263239, 0, 1, -1, 0], [3035674767, 0, 1, -1, 0], [261678880, 0, 1, -1, 0], [144783748, 0, 1, -1, 0], [2898830675, 0, 1, -1, 0], [2311413706, 0, 1, -1, 0], [1304635016, 0, 1, -1, 0], [3840356350, 4, 1, -1, 0], [1047093347, 0, 1, -1, 2], [3354177721, 0, 1, -1, 0], [3643362751, 0, 1, -1, 0], [698017395, 0, 1, -1, 0], [902020832, 3, 3, -1, 1], [2165627712, 2, 1, -1, 0], [3346844407, 0, 1, -1, 0], [3753034466, 1, 2, -1, 0], [881221695, 1, 1, -1, 0], [2144100145, 0, 1, -1, 0], [3749399219, 0, 0, -1, 0], [55060776, 1, 2, -1, 0], [3125584553, 1, 1, -1, 0], [2906015343, 2, 0, -1, 0], [219203323, 1, 1, -1, 0], [2854861606, 0, 1, -1, 1], [3884403666, 1, 1, -1, 0], [1041569008, 0, 1, -1, 0], [2780619238, 1, 1, -1, 0], [2839301427, 1, 1, -1, 0], [2481496956, 0, 1, -1, 0], [1305004983, 0, 1, -1, 0], [126562871, 2, 2, -1, 0], [3296195750, 0, 0, -1, 0]]},

		]
		[[4047587481, 0, 0, -1, 0], [1865079242, 0, 1, -1, 0], [3816091942, 3, 0, -1, 0], [4130837190, 0, 10, -1, 0], [1861568052, 0, 1, -1, 0], [1578940118, 1, 1, -1, 0], [1571676964, 0, 1, -1, 2], [1658164312, 2, 1, -1, 0], [98883956, 1, 1, -1, 0], [3114091169, 0, 1, -1, 0], [2570684145, 4, 1, -1, 2], [4007615411, 0, 1, -1, 0], [852550504, 3, 1, -1, 0], [4168223991, 0, 1, -1, 0], [478613943, 2, 1, -1, 1], [284670956, 0, 1, -1, 0], [2099185390, 0, 1, -1, 0], [1202202685, 0, 1, -1, 0], [3633864632, 0, 1, -1, 0], [3103053065, 0, 1, -1, 0], [820624960, 0, 1, -1, 0], [2599708267, 0, 1, -1, 0], [2885186814, 0, 1, -1, 0], [221503477, 0, 1, -1, 0], [1054317075, 0, 1, -1, 3], [683872522, 0, 1, -1, 1], [1739278764, 0, 2, -1, 0], [2855249023, 0, 1, -1, 0], [3721841948, 0, 1, -1, 0], [1365487849, 6, 1, -1, 0], [955229746, 0, 1, -1, 0], [3128009767, 0, 10, -1, 0], [441885003, 0, 1, -1, 0], [3433971238, 0, 1, -1, 2], [1038765354, 3, 1, -1, 0], [2973729510, 2, 1, -1, 0], [3884442008, 0, 1, -1, 0], [978673395, 1, 1, -1, 0], [4050927174, 0, 1, -1, 0], [1260103069, 0, 1, -1, 0], [4168894280, 0, 1, -1, 0], [2003494159, 1, 1, -1, 0], [2458926251, 1, 6, -1, 2], [4027800, 1, 6, -1, 3], [51193042, 0, 1, -1, 0], [2063302207, 1, 6, -1, 4], [2634540382, 3, 1, -1, 0], [886364171, 0, 1, -1, 0], [427713714, 0, 1, -1, 0], [3388129398, 0, 1, -1, 0], [446728522, 0, 1, -1, 0], [3305874255, 0, 1, -1, 0], [3316720711, 0, 1, -1, 0], [1126477623, 0, 1, -1, 0], [2617218444, 4, 1, -1, 2], [3615263239, 0, 1, -1, 0], [3035674767, 0, 1, -1, 0], [261678880, 0, 1, -1, 0], [144783748, 0, 1, -1, 0], [2898830675, 0, 1, -1, 0], [2311413706, 0, 1, -1, 0], [1304635016, 0, 1, -1, 0], [3840356350, 4, 1, -1, 0], [1047093347, 0, 1, -1, 2], [3354177721, 0, 1, -1, 0], [3643362751, 0, 1, -1, 0], [698017395, 0, 1, -1, 0], [902020832, 3, 3, -1, 1], [2165627712, 2, 1, -1, 0], [3346844407, 0, 1, -1, 0], [3753034466, 1, 2, -1, 0], [881221695, 1, 1, -1, 0], [2144100145, 0, 1, -1, 0], [3749399219, 0, 0, -1, 0], [55060776, 1, 2, -1, 0], [3125584553, 1, 1, -1, 0], [2906015343, 2, 0, -1, 0], [219203323, 1, 1, -1, 0], [2854861606, 0, 1, -1, 1], [3884403666, 1, 1, -1, 0], [1041569008, 0, 1, -1, 0], [2780619238, 1, 1, -1, 0], [2839301427, 1, 1, -1, 0], [2481496956, 0, 1, -1, 0], [1305004983, 0, 1, -1, 0], [126562871, 2, 2, -1, 0], [3296195750, 0, 0, -1, 0]]

Uh oh!

Conversation

BanTheNons commented Sep 21, 2021

Uh oh!

DiegoMagdaleno commented Sep 22, 2021

Uh oh!

DiegoMagdaleno Sep 22, 2021

Choose a reason for hiding this comment

Uh oh!

BanTheNons Sep 28, 2021

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

DiegoMagdaleno left a comment

Choose a reason for hiding this comment

Uh oh!

erkinalp commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BanTheNons commented Sep 28, 2021

Uh oh!

samuelscheit left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erkinalp Oct 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

erkinalp Oct 14, 2021

Choose a reason for hiding this comment

Uh oh!

erkinalp left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

erkinalp commented Sep 22, 2021 •

edited

Loading

samuelscheit left a comment •

edited

Loading

erkinalp Oct 14, 2021 •

edited

Loading