Skip to content

Conversation

@sudhanshu112233shukla
Copy link

fixes:#768

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Important

Review skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@CyberT17
Copy link
Contributor

I don't believe this fixes the issue. The issue is in how the docker image is created using the dockerfile.

@sudhanshu112233shukla
Copy link
Author

sudhanshu112233shukla commented Jan 21, 2026

@CyberT17 Thanks for pointing this out you were absolutely right. The root cause was the Dockerfile using a newer base image (node:24-alpine3.23), which implicitly pulled in Postgres 18 and led to the crash. I’ve now updated the PR to address this thoroughly. The Dockerfile has been downgraded to node:20-alpine3.19, ensuring that the embedded Postgres binary is version 16, which matches the Alpine 3.19 packages and resolves the issue for single-container deployments. In addition, the docker-compose.yml now explicitly pins POSTGRES_VERSION to 16, guaranteeing the same behavior and consistency for Compose users. With these changes in place, the upgrade incompatibility should be fully resolved and the PR is ready for re-review @msukkari @brendan-kellam

@brendan-kellam
Copy link
Contributor

@CyberT17 Thanks for pointing this out you were absolutely right. The root cause was the Dockerfile using a newer base image (node:24-alpine3.23), which implicitly pulled in Postgres 18 and led to the crash. I’ve now updated the PR to address this thoroughly. The Dockerfile has been downgraded to node:20-alpine3.19, ensuring that the embedded Postgres binary is version 16, which matches the Alpine 3.19 packages and resolves the issue for single-container deployments. In addition, the docker-compose.yml now explicitly pins POSTGRES_VERSION to 16, guaranteeing the same behavior and consistency for Compose users. With these changes in place, the upgrade incompatibility should be fully resolved and the PR is ready for re-review @msukkari @brendan-kellam

alpine 3.23 does appear to implicitly pull in postgres 18, but the fix shouldn't be to downgrade back to node:20-alpine3.19. Instead, pining the postgres version explicitly to 17 is a better solution. I'll open up a PR that does this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants