Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .claude/hooks/notify.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
#!/bin/bash
osascript -e "display notification \"Awaiting your input ($(date +%H:%M:%S))\" with title \"Claude Code\" sound name \"default\""
Comment on lines +1 to +2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

notify.shsettings.json에서 참조되지 않고 있어요.

  1. settings.json의 Notification 훅은 인라인 osascript 명령어를 직접 사용하고 있습니다.
  2. 이 스크립트(notify.sh)는 타임스탬프(HH:MM:SS)를 포함하는 더 나은 버전인데, 실제로는 어디서도 호출되지 않습니다.

둘 중 하나를 선택해 주세요:

  • settings.json에서 이 스크립트를 참조하도록 변경하거나,
  • 이 스크립트를 제거하고 인라인 명령어만 사용하거나.

현재 상태로는 dead code입니다.

🤖 Prompt for AI Agents
In @.claude/hooks/notify.sh around lines 1 - 2, The notify.sh script in
.claude/hooks is dead code because settings.json's Notification hook uses an
inline osascript command; either update settings.json to call the hook script
(e.g., point the Notification command to ".claude/hooks/notify.sh") so the
script with timestamp is used, or delete .claude/hooks/notify.sh and keep the
inline osascript in settings.json—make the change consistently (modify
settings.json's Notification entry or remove the file) and verify the
notification still works; target symbols: .claude/hooks/notify.sh and the
Notification entry in settings.json.

48 changes: 48 additions & 0 deletions .claude/hooks/post-edit-check.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
#!/usr/bin/env python3
import json
import sys
import re

data = json.load(sys.stdin)
file_path = data.get("tool_input", {}).get("file_path", "")

if not file_path.endswith(".java") or not file_path:
sys.exit(0)

try:
with open(file_path) as f:
content = f.read()
lines = content.split("\n")
except Exception:
sys.exit(0)

warnings = []

# 1. 와일드카드 import 체크
for i, line in enumerate(lines, 1):
if re.match(r"\s*import\s+.*\.\*;", line):
warnings.append(f"L{i}: 와일드카드 import 발견 -> 명시적 import 필요")

# 2. 파일 끝 줄바꿈 체크
if content and not content.endswith("\n"):
warnings.append("파일 끝 줄바꿈 누락")

# 3. Entity 클래스의 @Column 체크
if "@Entity" in content:
field_pattern = re.compile(r"^\s+private\s+\w+(?:<[^>]+>)?\s+\w+;")
relation_annotations = {
"@Column", "@Id", "@ManyToOne", "@OneToMany",
"@JoinColumn", "@OneToOne", "@ManyToMany",
"@Transient", "@Version", "@Embedded", "@EmbeddedId",
}
for i, line in enumerate(lines):
if field_pattern.match(line):
preceding = "\n".join(lines[max(0, i - 5):i])
has_annotation = any(ann in preceding for ann in relation_annotations)
if not has_annotation:
warnings.append(f"L{i + 1}: Entity 필드에 @Column 누락 가능성: {line.strip()}")

if warnings:
print(f"[컨벤션 체크 - {file_path.split('/')[-1]}]")
for w in warnings:
print(f" - {w}")
29 changes: 29 additions & 0 deletions .claude/settings.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
{
"env": {
"CLAUDE_CODE_EXPERIMENTAL_AGENT_TEAMS": "1"
},
"hooks": {
"Notification": [
{
"matcher": "",
"hooks": [
{
"type": "command",
"command": "osascript -e 'display notification \"Awaiting your input\" with title \"Claude Code\"'"
}
]
}
],
Comment on lines +6 to +16
Copy link

@coderabbitai coderabbitai bot Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

# First, let's find and examine notify.sh to compare implementations
find . -name "notify.sh" -o -name "post-edit-check.py" | head -20

Repository: solid-connection/solid-connect-server

Length of output: 141


🏁 Script executed:

# Let's look at the full .claude/settings.json file to understand the context
cat -n .claude/settings.json

Repository: solid-connection/solid-connect-server

Length of output: 858


🏁 Script executed:

# Search for any documentation or comments about matcher format in the codebase
rg -i "matcher" --type json -A 2 -B 2 | head -50

Repository: solid-connection/solid-connect-server

Length of output: 63


🌐 Web query:

Claude Code hooks settings.json matcher empty string behavior documentation

💡 Result:

In Claude Code hooks (~/.claude/settings.json, .claude/settings.json, etc.), the matcher is a regex string used to filter when a hook runs (for events that support matchers, like PreToolUse / PostToolUse). To match all occurrences, the docs explicitly say you can use:

  • "*"
  • an empty string: ""
  • or omit matcher entirely (i.e., leave it blank / not present)

So matcher: "" behaves like “match everything” for matcher-supported events. Also: if a matcher-supported event has a matcher and it doesn’t match, the hook group is skipped. For events that don’t support matchers (e.g., UserPromptSubmit, Stop), any matcher field is silently ignored. [1]

Source
[1] Claude Code Docs — “Hooks reference” (Matcher patterns) (docs.claude.com)

Citations:


🏁 Script executed:

# Read notify.sh to compare implementations
cat -n ./.claude/hooks/notify.sh

Repository: solid-connection/solid-connect-server

Length of output: 236


🏁 Script executed:

# Check if there's any documentation in the repo about Claude Code hooks
find . -name "*.md" -o -name "*.txt" | xargs grep -l "Notification\|hooks" 2>/dev/null | head -5

Repository: solid-connection/solid-connect-server

Length of output: 63


🌐 Web query:

Claude Code Notification event hook matcher support does matcher apply

💡 Result:

In Claude Code hooks, the matcher only applies to tool-name–based events (specifically PreToolUse and PostToolUse). For Notification (and also UserPromptSubmit, Stop, SubagentStop), matchers are not used, so you should omit the matcher field—you can’t filter Notification hooks by matcher. [1][2]


Notification 훅의 matcher 필드는 이 이벤트 타입에서 작동하지 않습니다.

  1. "matcher": "" 필드가 있지만, Claude Code의 Notification 이벤트는 매처를 지원하지 않습니다. 매처는 PreToolUsePostToolUse 이벤트에서만 적용되며, Notification에서는 무시됩니다. 따라서 이 필드는 제거하거나 그대로 두어도 됩니다.

  2. 인라인 osascript 대신 notify.sh를 활용하세요. 현재 설정의 알림 명령어는 notify.sh에 이미 구현되어 있지만, notify.sh 버전이 더 나은 기능을 포함하고 있습니다:

    • notify.sh: 타임스탐프 포함 ($(date +%H:%M:%S)) + 소리 알림 sound name "default"
    • 현재 인라인: 두 기능 모두 누락
  3. 코드 중복을 제거하고 notify.sh를 직접 호출하는 방식으로 통일하면 더 나을 것 같습니다.

🤖 Prompt for AI Agents
In @.claude/settings.json around lines 6 - 16, The Notification hook contains an
unsupported "matcher" field and uses an inline osascript command; remove the
unsupported "matcher" key from the "Notification" object and replace the inline
command "osascript -e 'display notification ...'" with a call to the existing
notify.sh script (e.g., invoke notify.sh with the same title/message so it uses
its timestamp and sound behavior). Update the "hooks" entry under "Notification"
to use type "command" and command "./notify.sh" (or the project-specific
notify.sh invocation) so Notification uses the standardized notify.sh
implementation instead of the inline osascript.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어라 이건 잠시 확인해보겠습니다~

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gyuhyeok99, 네, 확인해보시고 궁금한 점이나 추가로 필요한 정보가 있으시면 언제든지 말씀해주세요! 😊

제가 지적한 내용을 요약하자면:

  1. Notification 이벤트에서는 matcher 필드가 적용되지 않아 제거해도 됩니다
  2. 기존에 작성된 notify.sh 스크립트가 더 나은 기능(타임스탬프, 사운드)을 포함하고 있어, 인라인 명령어 대신 이 스크립트를 호출하는 것을 권장드립니다

"PostToolUse": [
{
"matcher": "Edit|Write",
"hooks": [
{
"type": "command",
"command": "python3 .claude/hooks/post-edit-check.py"
}
]
}
]
}
}
247 changes: 247 additions & 0 deletions .claude/skills/test/SKILL.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,247 @@
---
name: test
description: 테스트 코드를 작성하거나 수정할 때 이 프로젝트의 테스트 컨벤션과 패턴을 참고합니다
---

# 테스트 코드 작성 가이드

## 테스트 기본 설정

모든 통합 테스트는 `@TestContainerSpringBootTest` 어노테이션을 사용합니다.

```java
@TestContainerSpringBootTest
@DisplayName("채팅 서비스 테스트")
class ChatServiceTest {
// 테스트 코드
}
```

**제공 기능:**
- MySQL, Redis 자동 실행
- Spring Boot 컨텍스트 로드
- 테스트 후 자동 DB 초기화
- JUnit 5 기반

## Fixture 패턴

테스트 데이터는 Fixture로 생성합니다 (FixtureBuilder + Fixture 패턴).

**위치:** `src/test/java/com/example/solidconnection/[domain]/fixture/`

```
fixture/
├── [Entity]FixtureBuilder.java # Builder 패턴 구현
└── [Entity]Fixture.java # 편의 메서드 제공
```

### 예제: ChatRoomFixtureBuilder

```java
@TestComponent
@RequiredArgsConstructor
public class ChatRoomFixtureBuilder {

private final ChatRoomRepository chatRoomRepository;

private boolean isGroup;
private Long mentoringId;

public ChatRoomFixtureBuilder chatRoom() {
return new ChatRoomFixtureBuilder(chatRoomRepository);
}

public ChatRoomFixtureBuilder isGroup(boolean isGroup) {
this.isGroup = isGroup;
return this;
}

public ChatRoomFixtureBuilder mentoringId(long mentoringId) {
this.mentoringId = mentoringId;
return this;
}

public ChatRoom create() {
ChatRoom chatRoom = new ChatRoom(mentoringId, isGroup);
return chatRoomRepository.save(chatRoom); // DB 저장
}
}
```

### 예제: ChatRoomFixture

```java
@TestComponent
@RequiredArgsConstructor
public class ChatRoomFixture {

private final ChatRoomFixtureBuilder chatRoomFixtureBuilder;

// 편의 메서드: 기본값으로 생성
public ChatRoom 채팅방(boolean isGroup) {
return chatRoomFixtureBuilder.chatRoom()
.isGroup(isGroup)
.create();
}

public ChatRoom 멘토링_채팅방(long mentoringId) {
return chatRoomFixtureBuilder.chatRoom()
.mentoringId(mentoringId)
.isGroup(false)
.create();
}
}
```

**편의 메서드 작성 팁:**

- 한국어 메서드명 사용 (가독성)
- 자주 사용되는 기본값 조합만 제공
- Builder를 조합하여 필요한 데이터 설정

### 테스트에서 사용

```java
@TestContainerSpringBootTest
class ChatServiceTest {

@Autowired
private ChatRoomFixture chatRoomFixture;

@Test
void 채팅방을_생성할_수_있다() {
// 편의 메서드 사용
ChatRoom room = chatRoomFixture.채팅방(false);

// Builder 직접 사용
ChatRoom customRoom = chatRoomFixture.chatRoomFixtureBuilder.chatRoom()
.isGroup(true)
.mentoringId(100L)
.create();
}
}
```

## 테스트 네이밍 컨벤션

### 테스트 메서드 네이밍 규칙

테스트 메서드명은 **한국어로 명확하게** 작성하며, 다음 패턴을 따릅니다:

#### 1. 정상 동작 테스트

```java
// 패턴: 어떤_것을_하면_어떤_결과가_나온다
@Test
void 채팅방이_없으면_빈_목록을_반환한다() { ... }

@Test
void 최신_메시지_순으로_정렬되어_조회한다() { ... }

@Test
void 참여자는_메시지를_전송할_수_있다() { ... }

@Test
void 페이징이_정상_작동한다() { ... }
```

#### 2. 예외 테스트

```java
// 패턴: 어떤_것을_하면_예외_응답을_반환한다
@Test
void 참여하지_않은_채팅방에_접근하면_예외_응답을_반환한다() { ... }

@Test
void 존재하지_않는_사용자로_메시지를_전송하면_예외_응답을_반환한다() { ... }

@Test
void 권한이_없으면_예외_응답을_반환한다() { ... }

@Test
void 필수_파라미터가_없으면_예외_응답을_반환한다() { ... }
```

## BDD 테스트 작성

테스트는 Given-When-Then 구조로 작성합니다.

```java
@Test
@DisplayName("최신 메시지순으로 채팅방 목록을 조회한다")
void 최신_메시지_순으로_조회한다() {
// Given: 테스트 사전 조건
SiteUser user = siteUserFixture.사용자();
ChatRoom room1 = chatRoomFixture.채팅방(false);
ChatRoom room2 = chatRoomFixture.채팅방(false);
chatMessageFixture.메시지("오래된 메시지", user.getId(), room1);
chatMessageFixture.메시지("최신 메시지", user.getId(), room2);

// When: 실제 동작
ChatRoomListResponse response = chatService.getChatRooms(user.getId());

// Then: 결과 검증
assertAll(
() -> assertThat(response.chatRooms()).hasSize(2),
() -> assertThat(response.chatRooms().get(0).id()).isEqualTo(room2.getId())
);
}
```

## 테스트 그룹화 (@Nested)

기능별로 테스트를 그룹화합니다.

```java
@TestContainerSpringBootTest
class ChatServiceTest {

@Nested
@DisplayName("채팅방 목록 조회")
class 채팅방_목록을_조회한다 {

@Test
void 빈_목록을_반환한다() { ... }

@Test
void 최신_메시지_순으로_조회한다() { ... }
}

@Nested
@DisplayName("채팅 메시지 전송")
class 채팅_메시지를_전송한다 {

@BeforeEach
void setUp() {
// 이 그룹에만 적용되는 초기 설정
}

@Test
void 참여자는_메시지를_전송할_수_있다() { ... }
}
}
```

## 자주 사용하는 Assertion

```java
// 기본 검증
assertThat(value).isEqualTo(expected);
assertThat(value).isNotNull();

// 컬렉션
assertThat(list).hasSize(3);
assertThat(list).isEmpty();
assertThat(list).contains(item);

// 예외 검증
assertThatCode(() -> method())
.isInstanceOf(CustomException.class)
.hasMessage("error message");

// 복수 검증
assertAll(
() -> assertThat(a).isEqualTo(1),
() -> assertThat(b).isEqualTo(2)
);
```
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,9 @@ out/
### VS Code ###
.vscode/

### Claude Code ###
.claude/settings.local.json

### YML ###
application-secret.yml
application-prod.yml
Expand Down
1 change: 1 addition & 0 deletions .serena/.gitignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
/cache
Loading
Loading