SwipeableProps from RefObject to Ref#3759
Open
litinskii wants to merge 1 commit intosoftware-mansion:mainfrom
Open
SwipeableProps from RefObject to Ref#3759litinskii wants to merge 1 commit intosoftware-mansion:mainfrom
litinskii wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
latekvo
approved these changes
Oct 21, 2025
Member
There was a problem hiding this comment.
Thank you for the contribution!
Checked, this doesn't seem to cause any type issues, useImperativeHandle(ref, ...) which is the only usage of ref supports React.RefCallback.
The React.Ref type is a union type that includes:
string | number | null(legacy refs)
I don't think that's true, but that doesn't really matter 😅
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Fix ReanimatedSwipeable ref type to support ref callbacks
Description
This PR fixes the
refprop type inReanimatedSwipeablePropsto support both ref objects and ref callbacks, improving TypeScript compatibility and developer experience.Changes
ref?: React.RefObject<SwipeableMethods | null>toref?: React.Ref<SwipeableMethods | null>inReanimatedSwipeablePropsinterfaceMotivation
The current implementation only supports
React.RefObjectwhich limits developers to usinguseRef()hook. By changing toReact.Ref, the component now supports:useRef())This change aligns with React's best practices and provides more flexibility for developers when working with refs.
Example Usage
Before (only ref objects)
After (supports both ref objects and callbacks)
Type Safety
This change maintains full TypeScript type safety while expanding the supported ref patterns. The
React.Ref<T>type is a union type that includes:React.RefObject<T>React.RefCallback<T>Breaking Changes
None. This is a backward-compatible change that only expands the supported ref types.
Testing
Related Issues
Fixes the limitation where developers could only use
useRef()with ReanimatedSwipeable components.