[Collision.Geometry] Use StateAccessor and Topology accessor #5908
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alxbilger
added
pr: status to review
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
reviewed
Jan 30, 2026
| d_componentState.setValue(sofa::core::objectmodel::ComponentState::Valid); | ||
| if (!this->isComponentStateInvalid()) | ||
| { | ||
| this->validateMState(); |
Contributor
There was a problem hiding this comment.
validateMState() doesn't set the component state to be valid when the mstate exists. We either must change tje validateMSatet method or add a component state modification here
Contributor
Author
There was a problem hiding this comment.
Why does it have to be valid? The only useful information is knowing if the state is invalid or not, but the validity is not important. Specially because this class in designed to be a base class. In this case, we don't have any rule to set the state to valid. The most illustrative example is BaseObject::init.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to factorize the behavior, have the same common variables and expose the links.
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if