[All] Security : memory management, destructors and al #5904
+74
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
- Issue: fwrite() returns number of items written, not bytes. Comparison was incorrect. - Fix: Changed comparisons from == sizeof(DDSHeader) and == getImageSize() to == 1
…d cause undefined behavior when deleting derived objects through base pointers
…y leak in debug file
fredroy
force-pushed
the
fix_vulnerabilities_misc
branch
from
eb25a78 to
b0871a3
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
reviewed
Jan 30, 2026
Comment on lines
-154
to
+155
| volatile unsigned head; | ||
| volatile unsigned tail; | ||
| std::atomic<unsigned> head; | ||
| std::atomic<unsigned> tail; |
Contributor
There was a problem hiding this comment.
Not fully confident on that
| << " -crf 17 " | ||
| << " -vf vflip " | ||
| << "\"" << m_filename << "\""; // @TODO C++14 : replace with std::quoted | ||
| << "\"" << escapeForShell(m_filename) << "\""; |
Contributor
There was a problem hiding this comment.
Yeah ok, but the filename is something we create so this sanity check is maybe not required
|
|
||
| // delete argv copy | ||
| for (int i = 0; i < m_argc; i++) { | ||
| delete[] copyArgv[i]; |
Contributor
There was a problem hiding this comment.
Isn't this still required because we still have a vector of char* ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(the misc last part)
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if