[All] Security: unsafe string operations #5902
Open
+479
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
…handle invalid input and overflow conditions in string-to-number conversions
…t prevent buffer overflows
fredroy
force-pushed
the
fix_vulnerabilities_string
branch
from
0c9de53 to
8d9a23b
Compare
bakpaul
requested changes
Jan 30, 2026
Contributor
bakpaul
left a comment
bakpaul
left a comment
There was a problem hiding this comment.
I think you are going to hate me...
Comment on lines
+201
to
+202
| strncpy( dataFile, value, sizeof(dataFile) - 1 ); | ||
| dataFile[sizeof(dataFile) - 1] = '\0'; |
| { | ||
| dataFile[lenWithoutExt] = '\0'; | ||
| strncat( dataFile, "raw", sizeof(dataFile) - lenWithoutExt - 1 ); | ||
| } |
Contributor
There was a problem hiding this comment.
So many if without fallback. Maybe an error message somewhere ?
| r.name1.clear(); | ||
| } | ||
| else | ||
| r.group1 = 0; |
| r.name2.clear(); | ||
| } | ||
| else | ||
| r.group2 = 0; |
| errno = 0; | ||
| double val = std::strtod(c.c_str(), &endptr); | ||
| if (errno == 0 && endptr != c.c_str()) | ||
| values.push_back((Real)val); |
Contributor
There was a problem hiding this comment.
if, no fall back and no message...
Comment on lines
+36
to
+59
| namespace sofa::helper::deque_detail | ||
| { | ||
| inline bool safeStrToInt(const std::string& s, int& result) | ||
| { | ||
| char* endptr = nullptr; | ||
| errno = 0; | ||
| long val = std::strtol(s.c_str(), &endptr, 10); | ||
| if (errno != 0 || endptr == s.c_str() || val < INT_MIN || val > INT_MAX) | ||
| return false; | ||
| result = static_cast<int>(val); | ||
| return true; | ||
| } | ||
|
|
||
| inline bool safeStrToUInt(const std::string& s, unsigned int& result) | ||
| { | ||
| char* endptr = nullptr; | ||
| errno = 0; | ||
| unsigned long val = std::strtoul(s.c_str(), &endptr, 10); | ||
| if (errno != 0 || endptr == s.c_str() || val > UINT_MAX) | ||
| return false; | ||
| result = static_cast<unsigned int>(val); | ||
| return true; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Wow, this could have eased all of the previous boiling plate code that I reviewed. Could you kindly ask Claude to put that in a util file and use it everywhere instead of the crappy boiling plate code everywhere
Comment on lines
+37
to
+61
| namespace | ||
| { | ||
| bool safeStrToInt(const std::string& s, int& result) | ||
| { | ||
| char* endptr = nullptr; | ||
| errno = 0; | ||
| long val = std::strtol(s.c_str(), &endptr, 10); | ||
| if (errno != 0 || endptr == s.c_str() || val < INT_MIN || val > INT_MAX) | ||
| return false; | ||
| result = static_cast<int>(val); | ||
| return true; | ||
| } | ||
|
|
||
| bool safeStrToUInt(const std::string& s, unsigned int& result) | ||
| { | ||
| char* endptr = nullptr; | ||
| errno = 0; | ||
| unsigned long val = std::strtoul(s.c_str(), &endptr, 10); | ||
| if (errno != 0 || endptr == s.c_str() || val > UINT_MAX) | ||
| return false; | ||
| result = static_cast<unsigned int>(val); | ||
| return true; | ||
| } | ||
| } | ||
|
|
| } | ||
| catch (const std::exception&) | ||
| { | ||
| // Skip invalid entries |
| errno = 0; | ||
| long parsed = std::strtol(str, &endptr, 10); | ||
| if (errno != 0 || endptr == str) | ||
| continue; |
| errno = 0; | ||
| long val1 = std::strtol(params[0].c_str(), &endptr, 10); | ||
| if (errno != 0 || endptr == params[0].c_str() || val1 < INT_MIN || val1 > INT_MAX) | ||
| val1 = 0; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
unhandled exception from different string calls and replace unsafe calls of string functions
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if