[All] Security: fix overflows #5901
Open
+126
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fix
…reading and writing same buffer). Fixed: sscanf(buf, "%*127s %127s", matName); Breaking down the format: - %*127s - The * is the assignment suppression modifier. It means "read up to 127 chars but discard them (don't store)". This skips the first word (like "newmtl") - %127s - Read the second word (the material name), limited to 127 chars, store in matName So if buf contains "newmtl MyMaterial\n": - %*127s reads and discards "newmtl" - %127s reads "MyMaterial" into matName The 127 limit prevents buffer overflow since matName is 128 bytes (127 chars + null terminator).
… buffer overflows from size calculation wraparound
fredroy
force-pushed
the
fix_vulnerabilities_overflows
branch
from
cbcd999 to
e942da9
Compare
Contributor
Author
|
[ci-build][with-all-tests] |
bakpaul
requested changes
Jan 30, 2026
| result.resize(length); | ||
| for (int i = 0; i < length; i++) | ||
| result[i] = alphanum[rand() % length]; | ||
| result[i] = alphanum[rand() % alphanum.size()]; |
Comment on lines
+56
to
+61
| inline bool wouldOverflowCompliance(unsigned int a, unsigned int b) | ||
| { | ||
| if (a == 0 || b == 0) return false; | ||
| return a > std::numeric_limits<unsigned int>::max() / b; | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Yeah, not impressed... Why not in the meantime increase the size of the variable ? unsigned long ?
| vecString vLine; | ||
|
|
||
| char *l = new char[line.size()]; | ||
| char *l = new char[line.size() + 1]; |
| mat->name = buf; | ||
| { | ||
| char matName[128] = {0}; | ||
| sscanf(buf, "%*127s %127s", matName); |
Contributor
There was a problem hiding this comment.
Ok I don't understand this code.
Comment on lines
+865
to
+871
| if (lines.empty()) | ||
| { | ||
| m.resize(0, 0); | ||
| if( in.rdstate() & std::ios_base::eofbit ) { in.clear(); } | ||
| return in; | ||
| } | ||
|
|
Contributor
There was a problem hiding this comment.
Unecessary quick return... To be removed IMO
Comment on lines
+32
to
+38
| { | ||
| template<typename Index> | ||
| bool wouldOverflowBlock(Index a, Index b) | ||
| { | ||
| if (a <= 0 || b <= 0) return false; | ||
| return a > std::numeric_limits<Index>::max() / b; | ||
| } |
Contributor
There was a problem hiding this comment.
Many definitions of this same function, why not put it in a util file somewhere ?
|
|
||
| namespace | ||
| { | ||
| template<typename Index> |
Contributor
There was a problem hiding this comment.
SAme, could be replaced by a call to the util method with b=3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Different overflows risk were not checked,
and one array access is a bug (in BaseContactMapper)
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if