Skip to content

[All] Security: malloc checks #5900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
fredroy wants to merge 6 commits into
base: master
Choose a base branch
from
Open

[All] Security: malloc checks #5900

fredroy wants to merge 6 commits into from
+53 −15

Conversation

@fredroy
Copy link
Contributor

@fredroy fredroy commented Jan 29, 2026 •
edited
Loading

malloc() (and one calloc()) returns were never checked

[with-all-tests]

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@fredroy fredroy added pr: fix Fix a bug pr: status to review To notify reviewers to review this pull-request pr: ai-generated Label notifying the reviewers that part or all of the PR has been generated with the help of an AI labels Jan 29, 2026
@fredroy fredroy force-pushed the fix_vulnerabilities_malloc branch from 3ad3332 to 5b6208d Compare January 29, 2026 03:52
@fredroy
Copy link
Contributor Author

fredroy commented Jan 29, 2026

[ci-build][with-all-tests]

@hugtalbot hugtalbot added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 29, 2026
bakpaul
bakpaul reviewed Jan 30, 2026
View reviewed changes
Sofa/framework/Helper/src/sofa/helper/LCPcalc.cpp

// allocation de la mémoire nécessaire
mat = (SReal **)malloc(dim*sizeof(SReal *));
if (mat == nullptr)
Copy link
Contributor

@bakpaul bakpaul Jan 30, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could it be possible to add message to say "something went wrong while allocating memory, going out without computing the result". And this for all the cases ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bakpaul bakpaul bakpaul left review comments

@alxbilger alxbilger alxbilger approved these changes

@hugtalbot hugtalbot hugtalbot approved these changes

Assignees

No one assigned

Labels

pr: ai-generated Label notifying the reviewers that part or all of the PR has been generated with the help of an AI pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fredroy @alxbilger @hugtalbot @bakpaul