[Core] BaseObject: remove components from the slave list #5891
+6
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related (and fix) : #5890
Description:
Searching for memory leaks, I detected big ones coming from TetrahedronFEMForcefield.
In particular the colorMap, which was supposed to be deleted in the destructor.
I noticed that the destructor was not called and then... asked Claude which found that slaves was keeping a reference to their owner, and so the reference counter of the Sptr was not at the end of the program (so not the dtor was not called).
Easy solution is to unlink the slaves during the cleanup phase (what is done in this PR)
Only problem is if a component is overriding this function and not calling super::cleanup() 💀
(template method design blabla for BaseObject blabla 🫠)
[with-all-tests]
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if