Skip to content

Conversation

@hugtalbot
Copy link
Contributor

Changes according to cachix/install-nix-action#224


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: project-ci-infrastructure labels Jan 23, 2026
@hugtalbot hugtalbot changed the title Update cachix/install-nix-action to version 31 Update install-nix-action to version 31 Jan 23, 2026
@hugtalbot hugtalbot changed the title Update install-nix-action to version 31 [GitHub] Update install-nix-action to version 31 Jan 23, 2026
@sofa-framework sofa-framework deleted a comment from github-actions bot Jan 23, 2026
@sofa-framework sofa-framework deleted a comment from github-actions bot Jan 23, 2026
@fredroy fredroy force-pushed the hugtalbot-patch-2 branch 4 times, most recently from 24d429e to fe91e0f Compare January 28, 2026 05:37
@fredroy
Copy link
Contributor

fredroy commented Jan 28, 2026

@hugtalbot

I tried adding nholmann_json as a dependency as it was required to build, but now it is stuck on finding tight_inclusion which is not shipped by Nix (and certainly wont be).
Would it not be better to simply disable nix builds ?

@fredroy fredroy added the topic for next dev-meeting PR to be discussed in sofa-dev meeting label Jan 28, 2026
@olivier-roussel
Copy link
Contributor

I agree with @fredroy .
Unless somebody of us takes care of adding tight_inclusion to nix packages, it is quite unlikely this happens soon. So if we have nobody that can manage the nix support, may be we should drop it.
Also, we only have Nix support for SOFA, but not for any plugins right ? In this case it might be not quite useful.

@hugtalbot hugtalbot removed the topic for next dev-meeting PR to be discussed in sofa-dev meeting label Jan 30, 2026
@hugtalbot
Copy link
Contributor Author

New dependencies appeared in SOFA (nholmann_json, tight_inclusion) however tight_inclusion is not yet distributed with Nix. @nim65s would you have guidelines about this in order to keep the CI running?

@nim65s
Copy link
Contributor

nim65s commented Jan 30, 2026

the good long term solution is to add that package in nixpkgs.
the fast short term one is to add it here.

I'm doing both. that is https://github.com/Continuous-Collision-Detection/Tight-Inclusion, right ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: project-ci-infrastructure pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants