ENH: Time evolution Schechter amplitude#568
Open
Lucia-Fonseca wants to merge 7 commits intoskypyproject:mainfrom
Open
ENH: Time evolution Schechter amplitude#568Lucia-Fonseca wants to merge 7 commits intoskypyproject:mainfrom
Lucia-Fonseca wants to merge 7 commits intoskypyproject:mainfrom
Conversation
Member
Author
|
why is it not passing all of the checks? |
Contributor
|
Check the logs Given the relative numerical complexity of the function it seems reasonable that the results are not identical but agree to some high precision. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a function that returns the amplitude of the Schechter function for active galaxies based on equation (17) in de la Bella et al. 2021. Merging this PR closes #515.
Checklist