ENH: gravitational waves artale rates#474
Open
itrharrison wants to merge 23 commits intoskypyproject:module/gravitational_wavesfrom
Open
ENH: gravitational waves artale rates#474itrharrison wants to merge 23 commits intoskypyproject:module/gravitational_wavesfrom
itrharrison wants to merge 23 commits intoskypyproject:module/gravitational_wavesfrom
Conversation
ntessore
force-pushed
the
module/gravitational_waves-artale-rates
branch
from
09cbf83 to
a57d7b1
Compare
itrharrison
force-pushed
the
module/gravitational_waves-artale-rates
branch
from
a57d7b1 to
c5e1007
Compare
Member
|
@itrharrison could you please add |
itrharrison
changed the title
philipp128
requested changes
Jul 22, 2021
Member
Lucia-Fonseca
left a comment
Lucia-Fonseca
left a comment
There was a problem hiding this comment.
A few minor details, erase examples and question on private functions.
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: philipp128 <48715661+philipp128@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
Co-authored-by: Lucia F. de la Bella <55983939+Lucia-Fonseca@users.noreply.github.com>
…aves-artale-rates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new model for compact binary merger rates to the gravitational wave(s) module, from Artale et al (2020).
There are three models, depending cumulatively in each of stellar mass, star formation rate and metallicity. Each model is a simple logarithmic model with coefficients for the log of each independent variable and a constant.
The values of the parameters are fit to objects in the EAGLE simulation suite, with independent fits on simulation output at four redshifts: 0.1, 1, 2, 6. At the moment a simple linear interpolation between these points is performed for the coefficients as a function of redshift.
ToDo
Checklist