Skip to content

fix(logger): use direct env access for webpack inlining #2920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 1 commit into from
Jan 21, 2026
Merged

fix(logger): use direct env access for webpack inlining #2920

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 10 additions & 14 deletions packages/logger/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,19 @@ export interface LoggerConfig {
enabled?: boolean
}

/**
* Get environment variable value
* Works in any JavaScript runtime (Node.js, Bun, etc.)
*/
const getEnvVar = (key: string): string | undefined => {
const getNodeEnv = (): string => {
if (typeof process !== 'undefined' && process.env) {
return process.env[key]
return process.env.NODE_ENV || 'development'
}
return undefined
return 'development'
}

/**
* Get the current environment (development, production, test)
*/
const getNodeEnv = (): string => getEnvVar('NODE_ENV') || 'development'
const getLogLevel = (): string | undefined => {
if (typeof process !== 'undefined' && process.env) {
return process.env.LOG_LEVEL
}
return undefined
}

/**
* Get the minimum log level from environment variable or use defaults
Expand All @@ -56,7 +54,7 @@ const getNodeEnv = (): string => getEnvVar('NODE_ENV') || 'development'
* - Test: ERROR (only show errors in tests)
*/
const getMinLogLevel = (): LogLevel => {
const logLevelEnv = getEnvVar('LOG_LEVEL')
const logLevelEnv = getLogLevel()
if (logLevelEnv && Object.values(LogLevel).includes(logLevelEnv as LogLevel)) {
return logLevelEnv as LogLevel
}
Expand Down Expand Up @@ -120,7 +118,6 @@ const formatObject = (obj: unknown, isDev: boolean): string => {
stack: isDev ? obj.stack : undefined,
name: obj.name,
}
// Copy any additional enumerable properties from the error
for (const key of Object.keys(obj)) {
if (!(key in errorObj)) {
errorObj[key] = (obj as unknown as Record<string, unknown>)[key]
Expand Down Expand Up @@ -181,7 +178,6 @@ export class Logger {
private shouldLog(level: LogLevel): boolean {
if (!this.config.enabled) return false

// In production, only log on server-side (where window is undefined)
if (getNodeEnv() === 'production' && typeof window !== 'undefined') {
return false
}
Expand Down