Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • updated to useShallow from deprecated createWithEqualityFn to suppress Zustand warning

Type of Change

  • Improvement

Testing

N/A

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Jan 21, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Review Updated (UTC)
docs Skipped Skipped Jan 21, 2026 5:37pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Jan 21, 2026

Greptile Summary

Migrated use-editor-block-properties hook from deprecated Zustand shallow + useCallback pattern to modern useShallow hook.

Changes Made:

  • Replaced shallow from zustand/shallow with useShallow from zustand/react/shallow
  • Removed unnecessary useCallback wrappers around selector functions
  • Simplified code by 10 lines while maintaining identical functionality
  • Cleaned up comment that was no longer needed

Impact:

  • Suppresses Zustand deprecation warning as stated in PR description
  • Aligns with the established pattern used in 20+ other files across the codebase
  • No behavior change - useShallow provides the same shallow equality checking that shallow did
  • Slightly improved performance by eliminating useCallback overhead

Confidence Score: 5/5

  • This PR is safe to merge with minimal risk
  • The migration follows the established pattern used throughout the codebase, removes deprecated API usage, simplifies code by eliminating unnecessary useCallback wrappers, and maintains identical functionality with proper shallow equality checks
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/hooks/use-editor-block-properties.ts Migrated from deprecated shallow + useCallback pattern to modern useShallow hook, removing 10 lines of unnecessary code

Sequence Diagram

sequenceDiagram
    participant Editor as Editor Component
    participant Hook as useEditorBlockProperties
    participant WorkflowStore as useWorkflowStore
    participant DiffStore as useWorkflowDiffStore
    
    Editor->>Hook: useEditorBlockProperties(blockId, isSnapshotView)
    
    Hook->>WorkflowStore: useShallow(selector)
    Note over WorkflowStore: Selects advancedMode & triggerMode<br/>from blocks[blockId]
    WorkflowStore-->>Hook: { advancedMode, triggerMode }
    
    Hook->>DiffStore: useShallow(selector)
    Note over DiffStore: Selects advancedMode & triggerMode<br/>from baselineWorkflow.blocks[blockId]
    DiffStore-->>Hook: { advancedMode, triggerMode }
    
    Note over Hook: Returns appropriate props<br/>based on isSnapshotView
    
    Hook-->>Editor: { advancedMode, triggerMode }
Loading

@waleedlatif1 waleedlatif1 merged commit 268e2f1 into staging Jan 21, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the fix/xustand branch January 21, 2026 17:47
waleedlatif1 added a commit that referenced this pull request Jan 22, 2026
* fix(zustand): updated to useShallow from deprecated createWithEqualityFn (#2919)

* fix(logger): use direct env access for webpack inlining (#2920)

* fix(notifications): text overflow with line-clamp (#2921)

* chore(helm): add env vars for Vertex AI, orgs, and telemetry (#2922)

* fix(auth): improve reset password flow and consolidate brand detection (#2924)

* fix(auth): improve reset password flow and consolidate brand detection

* fix(auth): set errorHandled for EMAIL_NOT_VERIFIED to prevent duplicate error

* fix(auth): clear success message on login errors

* chore(auth): fix import order per lint

* fix(action-bar): duplicate subflows with children (#2923)

* fix(action-bar): duplicate subflows with children

* fix(action-bar): add validateTriggerPaste for subflow duplicate

* fix(resolver): agent response format, input formats, root level (#2925)

* fix(resolvers): agent response format, input formats, root level

* fix response block initial seeding

* fix tests

* fix(messages-input): fix cursor alignment and auto-resize with overlay (#2926)

* fix(messages-input): fix cursor alignment and auto-resize with overlay

* fixed remaining zustand warnings

* fix(stores): remove dead code causing log spam on startup (#2927)

* fix(stores): remove dead code causing log spam on startup

* fix(stores): replace custom tools zustand store with react query cache

* improvement(ui): use BrandedButton and BrandedLink components (#2930)

- Refactor auth forms to use BrandedButton component
- Add BrandedLink component for changelog page
- Reduce code duplication in login, signup, reset-password forms
- Update star count default value

* fix(custom-tools): remove unsafe title fallback in getCustomTool (#2929)

* fix(custom-tools): remove unsafe title fallback in getCustomTool

* fix(custom-tools): restore title fallback in getCustomTool lookup

Custom tools are referenced by title (custom_${title}), not database ID.
The title fallback is required for client-side tool resolution to work.

* fix(null-bodies): empty bodies handling (#2931)

* fix(null-statuses): empty bodies handling

* address bugbot comment

* fix(token-refresh): microsoft, notion, x, linear (#2933)

* fix(microsoft): proactive refresh needed

* fix(x): missing token refresh flag

* notion and linear missing flag too

* address bugbot comment

* fix(auth): handle EMAIL_NOT_VERIFIED in onError callback (#2932)

* fix(auth): handle EMAIL_NOT_VERIFIED in onError callback

* refactor(auth): extract redirectToVerify helper to reduce duplication

* fix(workflow-selector): use dedicated selector for workflow dropdown (#2934)

* feat(workflow-block): preview (#2935)

* improvement(copilot): tool configs to show nested props (#2936)

* fix(auth): add genericOAuth providers to trustedProviders (#2937)

---------

Co-authored-by: Vikhyath Mondreti <vikhyathvikku@gmail.com>
Co-authored-by: Emir Karabeg <78010029+emir-karabeg@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants