Merged
Conversation
Member
rossnelson
commented
Mar 4, 2025
- Introduced Logger interface and added logging to CircuitBreaker
- Refactored Config to include Logger
- Updated validateConfig to set default Logger if nil
- Added Breaker and JetStream interfaces
- Refactored Connector interface and related implementations
- Updated unit tests to mock new interfaces and logging
- Introduced Logger interface and added logging to CircuitBreaker - Refactored Config to include Logger - Updated validateConfig to set default Logger if nil - Added Breaker and JetStream interfaces - Refactored Connector interface and related implementations - Updated unit tests to mock new interfaces and logging
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
==========================================
+ Coverage 50.12% 51.69% +1.57%
==========================================
Files 126 126
Lines 4986 5002 +16
==========================================
+ Hits 2499 2586 +87
+ Misses 2349 2272 -77
- Partials 138 144 +6 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.