TT-7049 Enhance PlanView and TabAppBar making action bar sticky #194
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gtryus
commented
Jan 28, 2026
gtryus
commented
- Updated PlanView to apply top padding for sticky toolbar, ensuring proper spacing with ActionHeight.
- Refactored TabAppBar to fix mobile bar position and set its top value based on HeadHeight, enhancing mobile usability.
- Added Cypress tests for TabAppBar to verify fixed positioning and height attributes.
- Updated PlanView to apply top padding for sticky toolbar, ensuring proper spacing with ActionHeight. - Refactored TabAppBar to fix mobile bar position and set its top value based on HeadHeight, enhancing mobile usability. - Added Cypress tests for TabAppBar to verify fixed positioning and height attributes.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances the mobile view by making the PlanBar sticky and adjusting PlanView spacing accordingly. The changes ensure the action bar remains visible while scrolling on mobile devices.
Changes:
- Modified TabAppBar to use fixed positioning for mobile bar instead of unset positioning
- Updated PlanView to add top padding that accounts for the sticky toolbar height
- Added comprehensive Cypress tests to verify the positioning and spacing changes
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/renderer/src/control/TabAppBar.tsx | Changed mobile bar from position: 'unset' to position: 'fixed' with top: HeadHeight to make it sticky below the app header |
| src/renderer/src/control/TabAppBar.cy.tsx | Added new test file to verify mobile bar fixed positioning and height attributes |
| src/renderer/src/components/Sheet/PlanView.tsx | Added top padding calculation (ActionHeight + 16px) to prevent content overlap with sticky toolbar and imported ActionHeight |
| src/renderer/src/components/Sheet/PlanView.cy.tsx | Added test to verify the top padding is correctly applied to the Grid container |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.