Skip to content

Fix LT-22353: Change Hermit Crab to allow merge and split rules #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jtmaxwell3 merged 2 commits into from
Jan 29, 2026
Merged

Fix LT-22353: Change Hermit Crab to allow merge and split rules #646

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5004501
Fix LT-22353: Change Hermit Crab to allow merge and split rules
jtmaxwell3 Jan 28, 2026
467e411
Fix version of SIL.Machine
jtmaxwell3 Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Build/mkall.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,7 +236,7 @@
<ParatextNugetVersion>9.4.0.1-beta</ParatextNugetVersion>
<LcmNugetVersion>11.0.0-beta0149</LcmNugetVersion>
<IcuNugetVersion>70.1.123</IcuNugetVersion>
<HermitCrabNugetVersion>3.7.4</HermitCrabNugetVersion>
<HermitCrabNugetVersion>3.7.13</HermitCrabNugetVersion>
<IPCFrameworkVersion>1.1.1-beta0001</IPCFrameworkVersion>
<!-- bt393 is the master branch build of ExCss for Windows development. Update when appropriate. -->
<ExCssBuildType Condition="'$(OS)'=='Windows_NT'">bt393</ExCssBuildType>
Expand Down
4 changes: 2 additions & 2 deletions Build/nuget-common/packages.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,8 @@
<package id="SIL.libpalaso.l10ns" version="6.0.0" targetFramework="net461" />
<package id="SIL.Lift" version="17.0.0-beta0089" targetFramework="net462" />
<package id="SIL.Media" version="17.0.0-beta0089" targetFramework="net462" />
<package id="SIL.Machine" version="3.7.4" targetFramework="netstandard2.0" />
<package id="SIL.Machine.Morphology.HermitCrab" version="3.7.4" targetFramework="netstandard2.0" />
<package id="SIL.Machine" version="3.7.13" targetFramework="netstandard2.0" />
<package id="SIL.Machine.Morphology.HermitCrab" version="3.7.13" targetFramework="netstandard2.0" />
<package id="SIL.ParatextShared" version="7.4.0.1" targetFramework="net40" /> <!-- REVIEW (Hasso) 2023.05: do we still integrate with PT 7? -->
<package id="SIL.Scripture" version="17.0.0-beta0089" targetFramework="net462" />
<package id="SIL.TestUtilities" version="17.0.0-beta0089" targetFramework="net462" />
Expand Down
11 changes: 0 additions & 11 deletions Src/LexText/ParserCore/HCLoader.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2043,11 +2043,6 @@ private RewriteRule LoadRewriteRule(IPhRegularRule prule)
}
hcPrule.Properties[HCParser.PRuleID] = prule.Hvo;

if (hcPrule.Lhs.Children.Count > 1)
{
m_logger.InvalidRewriteRule(prule, ParserCoreStrings.ksMaxElementsInRule);
return null;
}
foreach (IPhSegRuleRHS rhs in prule.RightHandSidesOS)
{
var psubrule = new RewriteSubrule();
Expand Down Expand Up @@ -2098,12 +2093,6 @@ private RewriteRule LoadRewriteRule(IPhRegularRule prule)
psubrule.RightEnvironment = rightPattern;
}

if (psubrule.Rhs.Children.Count > 1)
{
m_logger.InvalidRewriteRule(prule, ParserCoreStrings.ksMaxElementsInRule);
return null;
}

hcPrule.Subrules.Add(psubrule);
}

Expand Down
11 changes: 1 addition & 10 deletions Src/LexText/ParserCore/ParserCoreStrings.Designer.cs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

3 changes: 0 additions & 3 deletions Src/LexText/ParserCore/ParserCoreStrings.resx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,4 @@
<data name="ksParsingX" xml:space="preserve">
<value>Parsing {0}</value>
</data>
<data name="ksMaxElementsInRule" xml:space="preserve">
<value>A rule can't have more than one element in its left-hand side or its right-hand side.</value>
</data>
</root>
Loading