LT-21492: Remove WritingSystemUpdated & WritingSystemDeleted #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cherry-pick from the PubSub branch to the main branch using the following command: git cherry-pick --no-commit 492707b Removed the unused code (LT-21492 and LT-21493). Only test code was passing a mediator in to the FwWritingSystemSetupModel constructor, so only test code was calling SendMessage for both of these events. The two delete tests that were failing an assert when I removed the mediator, both contain other asserts that still fail if the writing system is not deleted.
papeh
approved these changes
Jan 27, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick from the PubSub branch to the main branch using the following command:
git cherry-pick --no-commit 492707b
Removed the unused code (LT-21492 and LT-21493).
Only test code was passing a mediator in to the
FwWritingSystemSetupModel constructor, so only test code was calling SendMessage for both of these events.
The two delete tests that were failing an assert when I removed the mediator, both contain other asserts that still fail if the writing system is not deleted.
This change is