-
-
Notifications
You must be signed in to change notification settings - Fork 41
LT-22230: Add a method to increase the font size of parser test reports #642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
mark-sil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-sil reviewed 2 files and made 1 comment.
Reviewable status: 2 of 7 files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3).
Src/LexText/ParserUI/ParserListener.cs line 847 at r1 (raw file):
ReadParserReports(); // Create parser reports window. m_parserReportsDialog = new ParserReportsDialog(m_parserReports, m_mediator, m_cache, m_propertyTable, m_defaultComment);
Instead of using Pub/Sub to get to the ParserListener.ShowParserReport() can you add a ParserListener parameter to the ParserReportDialog constructor and the ParserReportsDialog constructor. They both look like they are only called from ParseListener so I think you can pass in 'this'.
mark-sil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-sil reviewed 5 files and all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @jtmaxwell3).
jtmaxwell3
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got rid of the Pub/Sub as requested.
@jtmaxwell3 made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mark-sil).
Src/LexText/ParserUI/ParserListener.cs line 847 at r1 (raw file):
Previously, mark-sil (Mark Kidder) wrote…
Instead of using Pub/Sub to get to the ParserListener.ShowParserReport() can you add a ParserListener parameter to the ParserReportDialog constructor and the ParserReportsDialog constructor. They both look like they are only called from ParseListener so I think you can pass in 'this'.
Done.
mark-sil
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mark-sil resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @jtmaxwell3).
This fixes https://jira.sil.org/browse/LT-22230. Whenever styles are edited then RefreshPopupWindowFonts is published. ParserListener subscribes to RefreshPopupWindowFonts and calls SetFont on each of the parser report windows to update the font. I changed the XAML files so that they would work with different font sizes. I also had to make ShowParserReport use the Pub/Sub model because it couldn't be a static function anymore because I needed m_parserReportDialogs to keep track of the parser reports.
This change is