More specific exception types and no more silent errors#868
Open
mathbou wants to merge 4 commits intoshotgunsoftware:masterfrom
Open
More specific exception types and no more silent errors#868mathbou wants to merge 4 commits intoshotgunsoftware:masterfrom
mathbou wants to merge 4 commits intoshotgunsoftware:masterfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #868 +/- ##
==========================================
- Coverage 79.87% 73.43% -6.44%
==========================================
Files 198 198
Lines 20719 20756 +37
==========================================
- Hits 16550 15243 -1307
- Misses 4169 5513 +1344 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zagpat
approved these changes
Mar 6, 2023
a320063 to
5cd3448
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
No new feature here, but a lot of comfort. Working using tk-core and the rest of the toolkit is very frustrating, as a lot of exceptions are catch silently and prints absolutely nothing to the log or the console. So this PR adds log to all silent exceptions.
Also, some
exceptwere missing an Exception type, and others were using the bare Exception instead of a more precise one, it's taken care of. Due to the code complexity, a lot of exceptions still need/use theExceptiontype, but it would be a good thing to get rid of them.As a "bonus", the QtImporter now raises an
ImportErrorinstead of returning a bunch of None.