Switch log.py's own logger to independant logger#861
Open
zagpat wants to merge 1 commit intoshotgunsoftware:masterfrom
Open
Switch log.py's own logger to independant logger#861zagpat wants to merge 1 commit intoshotgunsoftware:masterfrom
zagpat wants to merge 1 commit intoshotgunsoftware:masterfrom
Conversation
In case there is any kind of issue when setting up logger, use a specific logger for log calls. This avoids recursion issues when trying to operate "low level" calls on logger.
Codecov Report
@@ Coverage Diff @@
## master #861 +/- ##
==========================================
- Coverage 79.40% 72.88% -6.53%
==========================================
Files 177 177
Lines 19322 19333 +11
==========================================
- Hits 15343 14090 -1253
- Misses 3979 5243 +1264
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mathbou
approved these changes
Feb 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case there is any kind of issue when setting up logger, use a specific logger for log calls. This avoids recursion issues when trying to operate "low level" calls on the logger we are actually working with. This specific logger logs to a temp file unrelated to the rest of sgtk log files to avoid file access issues and specific maintenance.
About the possible recusion issues (this works in debug mode):
You may get stuck in a recursive loop.
In the same spirit of avoiding issues while working on "low level" operations, specifying exceptions we're catching to avoid catching exceptions unrelated to current process (and especially KeyboardInterrupt and the likes)