Open
Conversation
The problem is that the `create` operation contains initial data rather than a snapshot and `apply` requires the first param to be a snapshot. So, the original implementation worked only for the types which have the same type of initial data and snapshots.
Contributor
|
From the PR review meeting, @gkubisa linked #214 as an example of where this can cause an issue, with the custom text-tp2 OT type. @nateps's comments:
Greg suggests, if we do want to keep the performance benefit, adding an @nateps says that after talking about it, let's just merge this. |
Contributor
Author
|
Just to clarify, I agree with @nateps that the performance impact of this change is negligible. I mentioned |
Contributor
|
Suggest to close as stale. |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem is that the
createoperation contains initial data rather than a snapshot andapplyrequires the first param to be a snapshot. So, the original implementation worked only for the types which have the same type of initial data and snapshots.